Expire shared link when expire message#7629
Merged
nickvergessen merged 2 commits intomasterfrom Jul 27, 2022
Merged
Conversation
Signed-off-by: Vitor Mattos <vitor@php.rio>
vitormattos
added
3. to review
feature: api 🛠️
This was referenced Jul 22, 2022
Signed-off-by: Vitor Mattos <vitor@php.rio>
| $comment->setVerb(self::VERB_SYSTEM); | ||
| } | ||
|
|
||
| $this->setMessageExpiration($chat, $comment); |
Member
There was a problem hiding this comment.
This now expires all system messages, including "X added Y", not sure that is expected.
But for expiring call logs it definetly is expected, so I guess it's fine.
nickvergessen
approved these changes
Jul 27, 2022
nickvergessen
deleted the
feature/expire-shared-links-when-expire-message
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.