Skip to content

Conversation

@nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Sep 1, 2021

  • Add API endpoint to modify permissions for all attendees
  • Add API endpoint to set permissions for the conversation or the call
  • Add docs
  • Add unit tests
  • Add integration tests
  • Add events so updates trigger via HPB and internal signaling
  • ❓ Should we do a similar enhancement to setAttendeePermissions() which currently only allows to "set" instead of +/- a single permission?
  • Respect the ignore-lobby permission Waiting room to individually admit conversation participants #5394
    • ❓ What should happen with people that already joined and get "ignore-lobby" permission removed, are they kicked, or allowed to stay? Tendency is kicking makes lot's of things easier on technical level.
  • Store (default) permissions for conversations (so "start call" can be copied for new users etc.)
  • Deduplicate Attendee::PUBLISHING_PERMISSIONS_*
  • Requires Support separate permissions for publishing audio / video. strukturag/nextcloud-spreed-signaling#157

Fix #931
Fix #5394

The API allows to … a single or multiple permissions:

  • Add
  • Remove
  • Set

For either all participants or excluding moderators, guest moderators and owners.

I think we should do a similar enhancement to setAttendeePublishingPermissions which currently only allows to "set" instead of +/- a single permission.

@nickvergessen nickvergessen added 2. developing enhancement feature: api 🛠️ OCS API for conversations, chats and participants feature: meetings 📅 Covering the webinary usecase incl. Lobby labels Sep 1, 2021
@nickvergessen nickvergessen added this to the 💖 Next Major (23) milestone Sep 1, 2021
@nickvergessen nickvergessen self-assigned this Sep 1, 2021
@nickvergessen nickvergessen force-pushed the feature/931/allow-setting-publishing-permissions branch 2 times, most recently from c58c9f8 to 103b89c Compare September 1, 2021 12:45
@nickvergessen

This comment has been minimized.

@nickvergessen
Copy link
Member Author

Current plan:

I think we should do a similar enhancement to setAttendeePublishingPermissions which currently only allows to "set" instead of +/- a single permission.

Yes.

Additionally to the already existing code, we also add an endpoint that allows to set the default permissions for:

	public const PERMISSION_LOBBY = 1;
	public const PERMISSION_PUBLISH_AUDIO = 2;
	public const PERMISSION_PUBLISH_VIDEO = 4;
	public const PERMISSION_PUBLISH_SCREEN = 8;
	public const PERMISSION_CALL_START = 16;

Also the start call function gets extended with a parameter that can be used to set the permissions for this call. This will allow a moderator to start a meeting although in general the conversation would be free for all.

For this the Start/Join buttons are extended for moderators so they see:

  • Start call / Join call
  • Start call with only moderators publishing
  • Start call with only me speaking (moderators can start to publish but start disabled by default)

Similarly the Leave button is being extended to:

  • Leave call
  • End meeting for everyone

@nickvergessen nickvergessen force-pushed the feature/931/allow-setting-publishing-permissions branch 3 times, most recently from 3a087ee to f454365 Compare September 22, 2021 14:44
@nickvergessen nickvergessen force-pushed the feature/931/allow-setting-publishing-permissions branch from 2692fe5 to 2c47c7d Compare September 29, 2021 08:55
@nickvergessen nickvergessen force-pushed the feature/931/allow-setting-publishing-permissions branch from 32b2402 to 1ecc31f Compare October 4, 2021 15:49
@nickvergessen nickvergessen marked this pull request as ready for review October 4, 2021 15:49
@nickvergessen nickvergessen force-pushed the feature/931/allow-setting-publishing-permissions branch from 5eca7e1 to 97bd993 Compare October 6, 2021 18:47
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
… conversation permissions

Signed-off-by: Joas Schilling <coding@schilljs.com>
… HPB

Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen force-pushed the feature/931/allow-setting-publishing-permissions branch from 8f3fe75 to 007ba46 Compare October 7, 2021 16:18
Signed-off-by: Joas Schilling <coding@schilljs.com>
Copy link
Member

@marcoambrosini marcoambrosini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen merged commit 1e85995 into master Oct 7, 2021
@nickvergessen nickvergessen deleted the feature/931/allow-setting-publishing-permissions branch October 7, 2021 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review enhancement feature: api 🛠️ OCS API for conversations, chats and participants feature: meetings 📅 Covering the webinary usecase incl. Lobby

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Waiting room to individually admit conversation participants Allow moderators to set permissions for audio, video and screensharing in webinar

4 participants