Skip to content

Conversation

@nickvergessen
Copy link
Member

Fix #5730

@nickvergessen nickvergessen added 3. to review bug feature: chat 💬 Chat and system messages feature: api 🛠️ OCS API for conversations, chats and participants labels Jun 11, 2021
@nickvergessen nickvergessen added this to the 💖 Next Major (22) milestone Jun 11, 2021
@nickvergessen nickvergessen requested a review from PVince81 June 11, 2021 15:10
@nickvergessen
Copy link
Member Author

Unit tests need adjusting

@PVince81
Copy link
Member

code looks good so far, nice one!

Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen force-pushed the bugfix/5730/add-system-messages-for-group-attendees branch from 2408394 to e71e816 Compare June 14, 2021 07:51
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Copy link
Member Author

Ready to review

Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen merged commit 5be186b into master Jun 14, 2021
@nickvergessen nickvergessen deleted the bugfix/5730/add-system-messages-for-group-attendees branch June 14, 2021 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release bug feature: api 🛠️ OCS API for conversations, chats and participants feature: chat 💬 Chat and system messages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adding or removing a group from a room does not show a system chat message

3 participants