Skip to content

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Apr 10, 2021

Bumps @nextcloud/router from 1.2.0 to 2.0.0.

Changelog

Sourced from @​nextcloud/router's changelog.

2.0.0 - 2021-04-07

Changed

  • generateOcsUrl can now replace routing parameters like generateUrl
  • generateOcsUrl no longer contains a trailing slash unless given in the URL
  • Browserslist config updated, which means some older browsers are no longer supported
  • Dependency updates
Commits
  • 4c0b7a9 v2.0.0
  • b8fb765 Merge pull request #213 from nextcloud/dependabot/npm_and_yarn/babel/cli-7.13.14
  • a60cff6 Merge pull request #212 from nextcloud/dependabot/npm_and_yarn/babel/core-7.1...
  • fcbe75e Merge pull request #211 from nextcloud/dependabot/npm_and_yarn/core-js-3.10.0
  • e8db5a5 Bump @​babel/cli from 7.13.10 to 7.13.14
  • 6ebcd05 Bump @​babel/core from 7.13.13 to 7.13.14
  • e021512 Bump core-js from 3.9.1 to 3.10.0
  • 4eddff4 Merge pull request #210 from nextcloud/feature/194/ocs-url-parameters
  • 7485bfc Improve documentation
  • 1996e60 Allow to provide/inject URL parameters on OCS urls too
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually

@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript labels Apr 10, 2021
@nickvergessen
Copy link
Member

Need a lot of fixing

Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

touches all generateOcsUrl

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/nextcloud/router-2.0.0 branch from 8fe48aa to 6f45b81 Compare April 12, 2021 14:49
@nickvergessen nickvergessen added this to the 💖 Next Major (22) milestone Apr 14, 2021
@nickvergessen
Copy link
Member

We will only merge this close before the split off for stable22, so we can better backport things while it still matters.

@nickvergessen nickvergessen marked this pull request as draft April 14, 2021 14:37
dependabot bot and others added 2 commits May 19, 2021 13:01
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen force-pushed the dependabot/npm_and_yarn/nextcloud/router-2.0.0 branch from 6f45b81 to 2c55309 Compare May 19, 2021 11:27
@nickvergessen nickvergessen marked this pull request as ready for review May 19, 2021 11:27
@PVince81
Copy link
Member

We will only merge this close before the split off for stable22, so we can better backport things while it still matters.

the changes look good.

should we block the merge by discarding the bot's review ?

Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nickvergessen nickvergessen merged commit f821520 into master May 19, 2021
@nickvergessen nickvergessen deleted the dependabot/npm_and_yarn/nextcloud/router-2.0.0 branch May 19, 2021 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review dependencies Pull requests that update a dependency file javascript

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants