fix(auth): migrate authenticate.php to use vue-based form#17223
Open
fix(auth): migrate authenticate.php to use vue-based form#17223
Conversation
Antreesy
added
bug
feature: api 🛠️
Antreesy
force-pushed
the
fix/17192/public-room-guest-auth
branch
from
b95b82e to
39afa6c
Compare
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Antreesy
force-pushed
the
fix/17192/public-room-guest-auth
branch
from
39afa6c to
2d34959
Compare
DorraJaouad
reviewed
Feb 27, 2026
| </fieldset> | ||
| </form> | ||
| </div> | ||
| <div class="hidden-visually"><?php p($l->t('This conversation is password-protected.')); ?></div> |
Contributor
There was a problem hiding this comment.
You removed half of the condition tree (wrong password), it is fine to remove this div as well
Contributor
Author
There was a problem hiding this comment.
Was requested by Joas to keep it for security / bruteforce CI
| \OCP\Util::addStyle('core', 'publicshareauth'); | ||
| \OCP\Util::addScript('core', 'publicshareauth'); | ||
| /** @var array{share: \OCP\Share\IShare, identityOk?: bool, wrongpw?: bool} $_ */ | ||
| \OCP\Util::addStyle('spreed', 'talk-public-share-auth-form'); |
Contributor
Author
There was a problem hiding this comment.
Yes, when complied, vue component is split in JS and CSS (that included vue library styles as well)
| $initialState = \OCP\Server::get(\OCP\IInitialStateService::class); | ||
| $initialState->provideInitialState('spreed', 'talk-public-share-auth', [ | ||
| 'showBruteForceWarning' => $_['showBruteForceWarning'] ?? null, | ||
| 'wrongpw' => $_['wrongpw'] ?? null, |
Contributor
There was a problem hiding this comment.
Suggested change
| 'wrongpw' => $_['wrongpw'] ?? null, | |
| 'wrongPassword' => $_['wrongPassword'] ?? null, |
Contributor
Author
There was a problem hiding this comment.
I can change the key name for Vue component, by $_['wrongpw'] might be returned by server core, so I'm not messing with it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
🖌️ UI Checklist
🖼️ Screenshots / Screencasts
🏁 Checklist
🛠️ API Checklist
🚧 Tasks
🏁 Checklist
docs/has been updated or is not required