fix(filtering): Do not show filter unread mentions button while filtering#16634
Open
max65482 wants to merge 2 commits intonextcloud:mainfrom
Open
fix(filtering): Do not show filter unread mentions button while filtering#16634max65482 wants to merge 2 commits intonextcloud:mainfrom
max65482 wants to merge 2 commits intonextcloud:mainfrom
Conversation
…ring Signed-off-by: Maximilian Martin <maximilian_martin@gmx.de>
Member
|
It would still make sense when we are filtering by conversation names or for meeting conversations or unread messages in general? |
Contributor
|
Yeah, I'd say original issue is unclear about this. Button should not be shown, only if there are unread conversations out of screen, not when filtering |
Contributor
Author
|
Not sure if I got this right. Currently the button is hidden when filtering (for anything). |
Contributor
It should only be hidden, when:
|
…specifically Signed-off-by: Maximilian Martin <maximilian_martin@gmx.de>
Contributor
Author
|
Thanks for the clarification! Changed that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
🖌️ UI Checklist
🖼️ Screenshots / Screencasts
🚧 Tasks
🏁 Checklist