fix(polls): reduce amount of requests to poll results#16363
fix(polls): reduce amount of requests to poll results#16363
Conversation
- Now schedule an update of results, if was changed, and make an actual request upon dialog opening Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
| if (this.pollsStore.scheduledPolls[this.token]?.[value]) { | ||
| this.pollsStore.getPollData({ | ||
| token: this.token, | ||
| pollId: value, | ||
| }) | ||
| } |
There was a problem hiding this comment.
If we are just flushing requests upon opening poll viewer, we will lose the responsive UI when the dialog remains open (which I think it is the case for the polls that are created in the beginning of the webinars like Have you heard about Nextcloud before?)
There was a problem hiding this comment.
For chat relay, it is a must we get these information when someone votes:
- Actor who voted
- The option
- the poll Id
There was a problem hiding this comment.
For chat relay, it is a must we get these information when someone votes:
- Actor who voted
Only possible when it's a public poll :/
There was a problem hiding this comment.
Only possible when it's a public poll :/
Yes, we are not even receiving poll_voted for anonymous poll, so if we receive it, it is evident it is a public poll
nickvergessen
modified the milestones:
v23.0.0-beta.1,
🍏 Next Beta (33),
v23.0.0-beta.2,
🍏 Next RC (33)
3 participants
☑️ Resolves
🖌️ UI Checklist
🖼️ Screenshots / Screencasts
🏁 Checklist