Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace moment.unix() #14433

Merged
merged 2 commits into from
Feb 16, 2025
Merged

fix: replace moment.unix() #14433

merged 2 commits into from
Feb 16, 2025

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Feb 15, 2025

☑️ Resolves

  • Ref Remove moment.js #14434
  • Replace some of @nextcloud/moment functionality:
    • formatter moment().unix() replaced with convertToUnix() util
    • same done for all timestamp / 1000
    • constructor moment.unix(arg) returns the same result as moment(arg * 1000)

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

No visual change

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Not risky to browser differences / client
  • ⛑️ Tests are included or not possible

- formatter moment().unix() replaced with convertToUnix() util
- constructor moment.unix(arg) returns same result as moment(arg * 1000)

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy
Copy link
Contributor Author

/backport to stable31

@Antreesy Antreesy merged commit 5810c2c into main Feb 16, 2025
53 checks passed
@Antreesy Antreesy deleted the fix/noid/replace-moment-unix branch February 16, 2025 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants