fix: allow to create public room without password if password_policy enabled#14209
Merged
fix: allow to create public room without password if password_policy enabled#14209
Conversation
…enabled Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Antreesy
added
2. developing
bug
feature: api 🛠️
Member
provokateurin
left a comment
provokateurin
left a comment
There was a problem hiding this comment.
Can confirm it's broken and this change fixes it 👍
3 tasks
Contributor
Author
|
We discussed internally, that password_policy might not be considered in CI tests (or it's only this specific case), so any help with covering it is appreciated |
nickvergessen
approved these changes
Jan 27, 2025
Member
nickvergessen
left a comment
nickvergessen
left a comment
There was a problem hiding this comment.
Makes sense, but would be good to add a CI test for it.
We can do that in a follow up as well
Member
|
/backport to stable31 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
🛠️ API Checklist
🚧 Tasks
🏁 Checklist
docs/has been updated or is not required