Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(MessagesList): ease list around lastReadMessage #14205

Merged
merged 3 commits into from
Jan 27, 2025
Merged

fix(MessagesList): ease list around lastReadMessage #14205

merged 3 commits into from
Jan 27, 2025

Conversation

Antreesy
Copy link
Contributor

☑️ Resolves

  • Fix following case:
    • Open chat with 300+ unread messages, poll them all, switch to another chat, switch back - last read is no longer found, user is at the bottom of the chat, need to load old messages again
  • Drawbacks:
    • Need to poll all new messages again
      • should be fixed with message history (follow-up)
  • Known issues:
    • after page reload first rich text will be re-rendered again (async lib load)
      • drop async load or make workaround (follow-up)

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before

2025-01-23_18h32_19.mp4

🏡 After

2025-01-23_18h34_35.mp4

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible

@Antreesy
fix(MessagesList): disable smooth scroll to focused message when chat…
22eabd4 
… is initialized

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy
test(messagesStore): add a test for easeMessageList()
133764a 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy added this to the 🪺 Next Major (32) milestone Jan 23, 2025
@Antreesy Antreesy self-assigned this Jan 23, 2025
DorraJaouad
DorraJaouad reviewed Jan 24, 2025
View reviewed changes
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logic seems good

src/store/messagesStore.spec.js Show resolved Hide resolved
src/components/MessagesList/MessagesList.vue Show resolved Hide resolved
@Antreesy
fix(messagesStore): ease messages list around last read message
628071d 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy force-pushed the fix/noid/ease-message-list branch from 47e96bd to 628071d Compare January 24, 2025 14:15
DorraJaouad
DorraJaouad approved these changes Jan 27, 2025
View reviewed changes
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested 🦅

@Antreesy
Copy link
Contributor Author

/backport to stable31

@Antreesy Antreesy merged commit 6b93ad4 into main Jan 27, 2025
50 checks passed
@Antreesy Antreesy deleted the fix/noid/ease-message-list branch January 27, 2025 12:21
@backportbot backportbot bot mentioned this pull request Jan 27, 2025
Merged
@Antreesy Antreesy mentioned this pull request Feb 4, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DorraJaouad DorraJaouad DorraJaouad approved these changes

@ShGKme ShGKme Awaiting requested review from ShGKme

Assignees

@Antreesy Antreesy

Labels
3. to review bug feature: chat 💬 Chat and system messages feature: frontend 🖌️ "Web UI" client
Projects
None yet
Milestone
🪺 Next Major (32)
Development

Successfully merging this pull request may close these issues.
2 participants
@Antreesy @DorraJaouad