Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(hpb): Add a small heading to the call note #14085

Merged
merged 1 commit into from
Jan 9, 2025
Merged

fix(hpb): Add a small heading to the call note #14085

merged 1 commit into from
Jan 9, 2025

Conversation

nickvergessen
Copy link
Member

🖼️ Screenshots / Screencasts

grafik

@nickvergessen
fix(hpb): Add a small heading to the call note
6e722ab 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added 3. to review bug feature: settings ⚙️ Settings and config related issues labels Jan 9, 2025
@nickvergessen nickvergessen added this to the 🖤 Next Major (31) milestone Jan 9, 2025
@nickvergessen nickvergessen self-assigned this Jan 9, 2025
DorraJaouad
DorraJaouad approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also saw a warning in settings added recently for the same thing, shouldn't they be the same color (warning not error)?
image

@nickvergessen
Copy link
Member Author

Well users might not be able to do anything about it, so we only warn there and we want to highlight it important in the admin settings so we make it an error there

@nickvergessen nickvergessen merged commit 3398422 into main Jan 9, 2025
50 checks passed
@nickvergessen nickvergessen deleted the bugfix/noid/add-missing-headline branch January 9, 2025 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DorraJaouad DorraJaouad DorraJaouad approved these changes

@jancborchardt jancborchardt jancborchardt approved these changes

@Antreesy Antreesy Awaiting requested review from Antreesy

Assignees

@nickvergessen nickvergessen

Labels
3. to review bug feature: settings ⚙️ Settings and config related issues
Projects
None yet
Milestone
v21.0.0-beta.1
Development

Successfully merging this pull request may close these issues.
3 participants
@nickvergessen @jancborchardt @DorraJaouad