Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(calls): Allow moderators to download a call participants list - frontend #13557

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

DorraJaouad
Copy link
Contributor

☑️ Resolves

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

During call Output
image image

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@DorraJaouad DorraJaouad self-assigned this Oct 15, 2024
@DorraJaouad DorraJaouad force-pushed the feat/13453/download-call-participants-frontend branch from f12124b to 565a2f5 Compare October 15, 2024 14:13
@DorraJaouad DorraJaouad added this to the 🌠 Next Minor (30) milestone Oct 15, 2024
@DorraJaouad DorraJaouad marked this pull request as ready for review October 15, 2024 14:14
@Ivansss
Copy link
Member

Ivansss commented Oct 15, 2024

Just as an idea, would be possible to add this option somewhere in the participant list?

Somewhere here maybe?
Screenshot 2024-10-15 at 16 30 24

@Antreesy
Copy link
Contributor

Somewhere here maybe?

Maybe as a second entry, if it would feel needed there.
But then this section needs some rework

@DorraJaouad
Copy link
Contributor Author

Maybe as a second entry, if it would feel needed there.

I'd go for one entry only IMO.

Just as an idea, would be possible to add this option somewhere in the participant list?

We also thought it will fit better in participants tab but the current design doesn't help much in putting it there :').

Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
@DorraJaouad DorraJaouad force-pushed the feat/13453/download-call-participants-frontend branch from 565a2f5 to 05934fc Compare October 16, 2024 08:50
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. Filename change we can do separately on backend, right?

@DorraJaouad
Copy link
Contributor Author

DorraJaouad commented Oct 16, 2024

Filename change we can do separately on backend

As it is received from backend, I assumed it will be modified there. I am fine with adding it in this PR

// Limit to a reasonable length
$cleanedRoomName = substr($cleanedRoomName, 0, 100);
$date = (new \DateTime())->format('Y-m-d');
$fileName = "{$cleanedRoomName} - {$date}.csv";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe without an additional hyphen?

Suggested change
$fileName = "{$cleanedRoomName} - {$date}.csv";
$fileName = "{$cleanedRoomName} {$date}.csv";

Copy link
Member

@nickvergessen nickvergessen Oct 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In PHP we usually avoid these variables inside strings, so would be:

Suggested change
$fileName = "{$cleanedRoomName} - {$date}.csv";
$fileName = $cleanedRoomName . ' - ' . $date . '.csv';

or with Antreesy's comment:

Suggested change
$fileName = "{$cleanedRoomName} - {$date}.csv";
$fileName = $cleanedRoomName . ' ' . $date . '.csv';

or counterproposal:

Suggested change
$fileName = "{$cleanedRoomName} - {$date}.csv";
$fileName = $cleanedRoomName . '-' . $date . '.csv';

$cleanedRoomName = preg_replace('/-+/', '-', preg_replace('/[\/\\:*?"<>|]/', '-', $this->room->getName()));
// Limit to a reasonable length
$cleanedRoomName = substr($cleanedRoomName, 0, 100);
$date = (new \DateTime())->format('Y-m-d');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
$date = (new \DateTime())->format('Y-m-d');
$date = $this->timeFactory->getDateTime()->format('Y-m-d');

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it in UTC time because it is coming from server?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be, but we can inject the user's timezone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Moderators must be able to download the participant list as PDF and CSV
4 participants