-
Notifications
You must be signed in to change notification settings - Fork 434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(calls): Allow moderators to download a call participants list - frontend #13557
base: main
Are you sure you want to change the base?
Conversation
f12124b
to
565a2f5
Compare
Maybe as a second entry, if it would feel needed there. |
I'd go for one entry only IMO.
We also thought it will fit better in participants tab but the current design doesn't help much in putting it there :'). |
Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
565a2f5
to
05934fc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested. Filename change we can do separately on backend, right?
As it is received from backend, I assumed it will be modified there. I am fine with adding it in this PR |
// Limit to a reasonable length | ||
$cleanedRoomName = substr($cleanedRoomName, 0, 100); | ||
$date = (new \DateTime())->format('Y-m-d'); | ||
$fileName = "{$cleanedRoomName} - {$date}.csv"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe without an additional hyphen?
$fileName = "{$cleanedRoomName} - {$date}.csv"; | |
$fileName = "{$cleanedRoomName} {$date}.csv"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In PHP we usually avoid these variables inside strings, so would be:
$fileName = "{$cleanedRoomName} - {$date}.csv"; | |
$fileName = $cleanedRoomName . ' - ' . $date . '.csv'; |
or with Antreesy's comment:
$fileName = "{$cleanedRoomName} - {$date}.csv"; | |
$fileName = $cleanedRoomName . ' ' . $date . '.csv'; |
or counterproposal:
$fileName = "{$cleanedRoomName} - {$date}.csv"; | |
$fileName = $cleanedRoomName . '-' . $date . '.csv'; |
$cleanedRoomName = preg_replace('/-+/', '-', preg_replace('/[\/\\:*?"<>|]/', '-', $this->room->getName())); | ||
// Limit to a reasonable length | ||
$cleanedRoomName = substr($cleanedRoomName, 0, 100); | ||
$date = (new \DateTime())->format('Y-m-d'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
$date = (new \DateTime())->format('Y-m-d'); | |
$date = $this->timeFactory->getDateTime()->format('Y-m-d'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it in UTC time because it is coming from server?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be, but we can inject the user's timezone
☑️ Resolves
🖌️ UI Checklist
🖼️ Screenshots / Screencasts
🏁 Checklist