feat: draft polls management 📊 #13518

Antreesy · 2024-10-11T14:34:35Z

☑️ Resolves

Follow-up to feat: align polls state management with API #13516

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

Creation	Open poll

Closed poll	Shared Items

Filled	Empty

🚧 Tasks

Dialog + Placement
- Empty View
Draft deletion

🏁 Checklist

🌏 Tested with different browsers / clients:
- Chromium (Chrome / Edge / Opera / Brave)
- Firefox
- Safari
- Talk Desktop
- Not risky to browser differences / client
🖌️ Design was reviewed, approved or inspired by the design team
⛑️ Tests are included or not possible
📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>

DorraJaouad

Functionality works well

src/components/NewMessage/NewMessagePollEditor.vue

DorraJaouad · 2024-10-15T09:43:09Z

src/components/NewMessage/NewMessagePollEditor.vue

+			<NcActions v-if="supportPollDrafts" force-menu>
+				<NcActionButton v-if="isModerator" :disabled="!isFilled" @click="createPollDraft">


Conditions can be merged on NcActions level

I thought of 'Export draft to file', which should be allowed to non-moderators

I don't think it should be allowed to non-moderators, cc @nickvergessen

DorraJaouad · 2024-10-15T11:46:29Z

src/components/NewMessage/NewMessagePollEditor.vue

+			<NcActions v-if="supportPollDrafts" force-menu>
+				<NcActionButton v-if="isModerator" close-after-click @click="openPollDraftHandler">
+					<template #icon>
+						<IconFileEdit :size="20" />
+					</template>
+					{{ t('spreed', 'Browse poll drafts') }}
+				</NcActionButton>
+			</NcActions>


Conditions on same level here too?

src/components/PollViewer/PollDraftHandler.vue

src/components/NewMessage/NewMessagePollEditor.vue

DorraJaouad · 2024-10-15T12:02:00Z

src/components/PollViewer/PollDraftHandler.vue

+-->
+
+<template>
+	<NcDialog class="drafts"


Make it bigger so it can hide the other dialog?

Or close that modal once this is open.
A good addition would be to rename the button to "Back" instead of "Create a new poll" when it's opened from poll editor :). The flow would make sense much better.

I'd just hide the button in case PollEditor is open (as we can see it behind), but don't close it, like ConversationSettings dialog stays behind while you're checking bans - subfeature on top of main one.

Besides, PollEditor can be larger if there are more answers filled. Though we can squezee drafts dialog to 2 drafts in a row?

3 2

I'd just hide the button in case PollEditor is open (as we can see it behind), but don't close it, like ConversationSettings dialog stays behind while you're checking bans - subfeature on top of main one.

Fine by me, but I'd still prefer renaming it to "back"

Besides, PollEditor can be larger if there are more answers filled. Though we can squezee drafts dialog to 2 drafts in a row?

Yes, but we should cover all scenarios. It needs to have a default height and width that can cover the poll editor ?

DorraJaouad · 2024-10-15T12:06:05Z

src/components/NewMessage/NewMessagePollEditor.vue

+					</template>
+					{{ t('spreed', 'Save as draft') }}


I might be influenced by github but I expected to find this button in a menu with "Create draft" but not like we have in CallButton (you can press directly "create draft" but for "Save as draft" needs to click on the down arrow button and then click on it). So basically, make the 3 dot icon a down arrow and attach it to the "create draft".

There is a discussion about this type of buttons for call button so we can change it later once we agree on using it.

Like this?

Looks nice for me, but IIRC design team is against that styling

cc @marcoambrosini

I find really nice and intuitive, maybe 3 dot is to be replaced with down arrow

I think these two actions are not related, so I wouldn't group them. Taking into account how advanced this feature is, I would just add an unlabelled "save" button to the left of the primary action. We can also remove the dismiss button since we already have the close dialog close button

to the left of the primary action

Thing is, we might want to extend the actions range (+ export to file, for example). But without a 'Dismiss' button three-dot menu should already look better

src/components/NewMessage/NewMessage.vue

src/components/NewMessage/NewMessagePollEditor.vue

…olls Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>

Antreesy added 2. developing feature: frontend 🖌️ "Web UI" client feature: polls 📊 labels Oct 11, 2024

Antreesy added this to the 🖤 Next Major (31) milestone Oct 11, 2024

Antreesy self-assigned this Oct 11, 2024

Antreesy mentioned this pull request Oct 11, 2024

feat: align polls state management with API #13516

Merged

12 tasks

Antreesy force-pushed the feat/13439/drafts-for-polls-frontend branch from 06413e0 to 9c30404 Compare October 14, 2024 07:40

feat: save poll drafts from filled forms, created and closed polls

935aae4

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>

Base automatically changed from feat/13439/drafts-for-polls-frontend to main October 14, 2024 10:11

An error occurred while trying to automatically change base from feat/13439/drafts-for-polls-frontend to main October 14, 2024 10:11

Antreesy force-pushed the feat/13439/drafts-for-polls-frontend-2 branch from 5ad83f9 to 529d2de Compare October 14, 2024 13:42

Antreesy requested a review from DorraJaouad October 14, 2024 13:46

Antreesy added 3 commits October 14, 2024 20:41

feat: browse poll drafts from poll editor and shared items

1dd81b4

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>

feat: create new poll from drafts

a94d0f1

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>

feat: delete poll drafts

c22c94f

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>

Antreesy force-pushed the feat/13439/drafts-for-polls-frontend-2 branch from 529d2de to c22c94f Compare October 14, 2024 18:45

Antreesy marked this pull request as ready for review October 14, 2024 18:45

DorraJaouad reviewed Oct 15, 2024

View reviewed changes

Antreesy added 3 commits October 15, 2024 16:17

fixup! feat: save poll drafts from filled forms, created and closed p…

ecf2279

…olls Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>

fixup! feat: browse poll drafts from poll editor and shared items

7b7b3c9

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>

[skip ci] fixup! feat: create new poll from drafts

2dc84b2

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: draft polls management 📊 #13518

feat: draft polls management 📊 #13518

Antreesy commented Oct 11, 2024 •

edited

Loading

DorraJaouad left a comment

DorraJaouad Oct 15, 2024

Antreesy Oct 15, 2024

DorraJaouad Oct 15, 2024

DorraJaouad Oct 15, 2024

Antreesy Oct 15, 2024

DorraJaouad Oct 15, 2024

Antreesy Oct 15, 2024 •

edited

Loading

DorraJaouad Oct 16, 2024

DorraJaouad Oct 15, 2024

Antreesy Oct 15, 2024 •

edited

Loading

Antreesy Oct 16, 2024

DorraJaouad Oct 16, 2024

marcoambrosini Oct 16, 2024

Antreesy Oct 16, 2024

		<NcActions v-if="supportPollDrafts" force-menu>
		<NcActionButton v-if="isModerator" :disabled="!isFilled" @click="createPollDraft">

feat: draft polls management 📊 #13518

Are you sure you want to change the base?

feat: draft polls management 📊 #13518

Conversation

Antreesy commented Oct 11, 2024 • edited Loading

☑️ Resolves

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🚧 Tasks

🏁 Checklist

DorraJaouad left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Antreesy Oct 15, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Antreesy Oct 15, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Antreesy commented Oct 11, 2024 •

edited

Loading

Antreesy Oct 15, 2024 •

edited

Loading

Antreesy Oct 15, 2024 •

edited

Loading