fix: handle background blur in Talk if server doesn't support it #13507
Conversation
Antreesy
added
3. to review
regression
feature: frontend 🖌️
|
Talk Desktop is locked on v25.0.2, so it will use fallback: https://github.com/nextcloud/talk-desktop/blob/a3ce89690df2a88b2d90b4cd54186b2c06c31673/src/shared/setupWebPage.js#L172 |
|
/backport to stable30 |
- partially reverts ed39a6b Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
- post-review refactoring Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Antreesy
force-pushed
the
fix/12633/check-server-version-for-blur
branch
from
d979129
to
21c4620
Compare
|
rebased onto webpack-vue-config 6.2.0, all changes since last review are in 2nd commit (for backport to 29) |
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
| /** | ||
| * Fallback style for versions before v29.0.4 | ||
| */ | ||
| callContainerStyle() { | ||
| if (serverSupportsBackgroundBlurred) { | ||
| return | ||
| } | ||
|
|
||
| return { | ||
| 'backdrop-filter': this.isBackgroundBlurred ? 'blur(25px)' : 'none', | ||
| } | ||
| } |
There was a problem hiding this comment.
nitpick: instead of adding an inline styles object here, it's better to bind a class in the template and add styles in <style>
There was a problem hiding this comment.
I couldn't find a nice-looking solution, given that we need to overwrite any backdrop value coming from server. See screenshot from 29.0.3:
Any thoughts? can also keep only 'blur none' option for DefaultTheme and not affect HighContrast ones?
src/components/CallView/CallView.vue
Outdated
| const serverVersion = loadState('core', 'config', {}).versionstring ?? '29.0.0' | ||
| const serverSupportsBackgroundBlurred = '29.0.4'.localeCompare(serverVersion) < 1 |
There was a problem hiding this comment.
We don't backport further, so i think, it would be enough for this exact feature
There was a problem hiding this comment.
But it is about server version, not Talk version, right?
There was a problem hiding this comment.
yes, we get NC server version, as this is where blur toggle was implemented in User settings
☑️ Resolves
🖌️ UI Checklist
🖼️ Screenshots / Screencasts
🏁 Checklist