add app-specific favicon for better recognition among tabs#133
Merged
jancborchardt merged 1 commit intomasterfrom Nov 24, 2016
Merged
add app-specific favicon for better recognition among tabs#133jancborchardt merged 1 commit intomasterfrom
jancborchardt merged 1 commit intomasterfrom
Conversation
img/favicon-mask.svg
Outdated
| @@ -0,0 +1,2 @@ | |||
| <?xml version="1.0" encoding="UTF-8" standalone="no"?> | |||
| <svg xmlns="http://www.w3.org/2000/svg" xml:space="preserve" height="16" viewBox="0 0 16 15.999999" width="16" version="1.1" y="0px" x="0px" enable-background="new 0 0 595.275 311.111"><path d="m2.5 0c-1.385 0-2.5 1.115-2.5 2.5v11c0 1.385 1.115 2.5 2.5 2.5h11c1.385 0 2.5-1.115 2.5-2.5v-11c0-1.385-1.115-2.5-2.5-2.5h-11zm0.5 3h6c1.108 0 2 0.892 2 2v1.334l4-3.334v10l-4-3.334v1.334c0 1.108-0.892 2-2 2h-6c-1.108 0-2-0.892-2-2v-6c0-1.108 0.892-2 2-2z"/></svg> | |||
Member
There was a problem hiding this comment.
fix the viewbox please to 16 instead of 15.99999999
Member
Author
There was a problem hiding this comment.
Woah why did that happen :D
img/favicon-touch.svg
Outdated
| @@ -0,0 +1,2 @@ | |||
| <?xml version="1.0" encoding="UTF-8" standalone="no"?> | |||
| <svg xmlns="http://www.w3.org/2000/svg" xml:space="preserve" height="128" viewBox="0 0 128 127.99999" width="128" version="1.1" y="0px" x="0px" enable-background="new 0 0 595.275 311.111"><rect rx="20" ry="20" height="128" width="128" y="-.0000015" x="0" fill="#0082c9"/><path fill="#fff" d="m24 24c-8.864 0-16 7.136-16 16v48c0 8.864 7.136 16 16 16h48c8.864 0 16-7.136 16-16v-10.672l32 26.672v-80l-32 26.672v-10.672c0-8.864-7.136-16-16-16z"/></svg> | |||
img/favicon.svg
Outdated
| @@ -0,0 +1,2 @@ | |||
| <?xml version="1.0" encoding="UTF-8" standalone="no"?> | |||
| <svg xmlns="http://www.w3.org/2000/svg" xml:space="preserve" height="32" viewBox="0 0 32 31.999997" width="32" version="1.1" y="0px" x="0px" enable-background="new 0 0 595.275 311.111"><rect rx="5" ry="5" height="32" width="32" y="-.0000052588" x="0" fill="#0082c9"/><path fill="#fff" d="m6 6c-2.216 0-4 1.784-4 4v12c0 2.216 1.784 4 4 4h12c2.216 0 4-1.784 4-4v-2.668l8 6.668v-20l-8 6.668v-2.668c0-2.216-1.784-4-4-4z"/></svg> | |||
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
jancborchardt
force-pushed
the
favicons
branch
from
8906861 to
a217042
Compare
Member
Author
|
Fixed, will also fix in the other apps where this was always copied over from. |
Current coverage is 8.81% (diff: 100%)@@ master #133 diff @@
========================================
Files 13 13
Lines 953 953
Methods 61 61
Messages 0 0
Branches 0 0
========================================
Hits 84 84
Misses 869 869
Partials 0 0
|
Member
|
Btw this is not themed anymore then, right? 😞 |
Member
Author
|
Good question actually, I thought maybe nextcloud/server#840 by @juliushaertl fixes this? :) Because we have custom favicons in Mail, Calendar, Contacts and Notes since some time already. |
Closed
marcoambrosini
pushed a commit
that referenced
this pull request
Oct 9, 2019
Allow above multiselect
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check it @LukasReschke @Ivansss @nickvergessen @MorrisJobke