Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: replace emoji-mart-vue-fast lib usage with nextcloud/vue function #12285

Merged
merged 2 commits into from
May 7, 2024
Merged

fix: replace emoji-mart-vue-fast lib usage with nextcloud/vue function #12285

merged 2 commits into from
May 7, 2024

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented May 6, 2024 •
edited
Loading

☑️ Resolves

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
image image

🏁 Checklist

  • 🌏 Tested with Chrome, Firefox and Safari or should not be risky to browser differences
  • 🖥️ Tested with Desktop client or should not be risky for it

@Antreesy Antreesy added 3. to review feature: frontend 🖌️ "Web UI" client dependencies Pull requests that update a dependency file labels May 6, 2024
@Antreesy Antreesy added this to the 💙 Next Major (30) milestone May 6, 2024
@Antreesy Antreesy requested review from ShGKme and DorraJaouad May 6, 2024 14:59
@Antreesy Antreesy self-assigned this May 6, 2024
@ShGKme ShGKme mentioned this pull request May 7, 2024
Merged
2 tasks
Antreesy added 2 commits May 7, 2024 16:59
@Antreesy
fix: replace emoji-mart-vue-fast lib usage with nextcloud/vue function
90054ad 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy
chore(deps): uninstall emoji-mart-vue-fast library
87346e0 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy force-pushed the fix/noid/remove-emoji-mart-vue-fast branch from 42f1a07 to 87346e0 Compare May 7, 2024 15:04
@Antreesy Antreesy marked this pull request as ready for review May 7, 2024 15:04
@Antreesy Antreesy mentioned this pull request May 7, 2024
Open
66 tasks
@Antreesy Antreesy merged commit 9db45b6 into main May 7, 2024
48 checks passed
@Antreesy Antreesy deleted the fix/noid/remove-emoji-mart-vue-fast branch May 7, 2024 15:39
@Antreesy
Copy link
Contributor Author

Antreesy commented May 7, 2024

/backport to stable29

@backportbot backportbot bot mentioned this pull request May 7, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DorraJaouad DorraJaouad DorraJaouad approved these changes

@ShGKme ShGKme ShGKme approved these changes

Assignees

@Antreesy Antreesy

Labels
3. to review dependencies Pull requests that update a dependency file feature: frontend 🖌️ "Web UI" client
Projects
None yet
Milestone
v20.0.0-beta.1
Development

Successfully merging this pull request may close these issues.
3 participants
@Antreesy @ShGKme @DorraJaouad