-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(files-sidebar): reduce initial loading size of Files sidebar #11551
Open
Antreesy
wants to merge
1
commit into
main
Choose a base branch
from
perf/noid/reduce-initial-sidebar-bundle
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Antreesy
added
2. developing
feature: frontend 🖌️
"Web UI" client
feature: talk-sidebar ⬅️
Sidebar integration of Talk into other apps like sharing and documents
performance 🚀
labels
Feb 8, 2024
nickvergessen
requested changes
Feb 8, 2024
Antreesy
force-pushed
the
perf/noid/reduce-initial-sidebar-bundle
branch
from
February 9, 2024 13:33
7aa4a1e
to
a7feca1
Compare
ShGKme
reviewed
Feb 9, 2024
Antreesy
force-pushed
the
perf/noid/reduce-initial-sidebar-bundle
branch
from
February 12, 2024 15:49
a7feca1
to
b3f1f06
Compare
nickvergessen
modified the milestones:
v19.0.0-beta.3,
💞 Next Beta (29),
v19.0.0-beta.4,
💙 Next Major (30)
Mar 19, 2024
Antreesy
force-pushed
the
perf/noid/reduce-initial-sidebar-bundle
branch
2 times, most recently
from
May 29, 2024 13:12
787d5b7
to
d2a8064
Compare
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
ShGKme
force-pushed
the
perf/noid/reduce-initial-sidebar-bundle
branch
from
June 19, 2024 13:38
d2a8064
to
618fbc7
Compare
Rebased onto |
get in? backport? |
Tested once again, works correctly. Most of the JS code (1 Mb in dev) is loaded after sidebar is opened and DOMContentLoaded, so somewhat a boost. I'm fine with both options |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
2. developing
feature: frontend 🖌️
"Web UI" client
feature: talk-sidebar ⬅️
Sidebar integration of Talk into other apps like sharing and documents
performance 🚀
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
🖌️ UI Checklist
🖼️ Screenshots / Screencasts
🚧 Tasks
🏁 Checklist