Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(files-sidebar): reduce initial loading size of Files sidebar #11551

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Feb 8, 2024

☑️ Resolves

  • Changes:
    • Initial sidebar tab registration takes only a loading placeholder
    • When tab becomes active, component triggers async load of main content and replace placeholder
    • From that moment, all logic should remain the same, only main content will be used for tab mounting

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
image image
481 kB initial + 1.5 MB (chat + call) 41 kB initial + 1.2 MB (chat + call)
image image

🚧 Tasks

  • Check properly

🏁 Checklist

@Antreesy Antreesy added 2. developing feature: frontend 🖌️ "Web UI" client feature: talk-sidebar ⬅️ Sidebar integration of Talk into other apps like sharing and documents performance 🚀 labels Feb 8, 2024
@Antreesy Antreesy added this to the 💞 Next Major (29) milestone Feb 8, 2024
@Antreesy Antreesy self-assigned this Feb 8, 2024
src/mainFilesSidebarLoader.js Outdated Show resolved Hide resolved
@Antreesy Antreesy force-pushed the perf/noid/reduce-initial-sidebar-bundle branch from 7aa4a1e to a7feca1 Compare February 9, 2024 13:33
@Antreesy Antreesy force-pushed the perf/noid/reduce-initial-sidebar-bundle branch from a7feca1 to b3f1f06 Compare February 12, 2024 15:49
@Antreesy Antreesy requested a review from danxuliu March 1, 2024 15:10
@Antreesy Antreesy force-pushed the perf/noid/reduce-initial-sidebar-bundle branch 2 times, most recently from 787d5b7 to d2a8064 Compare May 29, 2024 13:12
@Antreesy Antreesy marked this pull request as ready for review May 29, 2024 13:14
@nickvergessen nickvergessen requested a review from ShGKme June 7, 2024 14:49
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@ShGKme ShGKme force-pushed the perf/noid/reduce-initial-sidebar-bundle branch from d2a8064 to 618fbc7 Compare June 19, 2024 13:38
@ShGKme
Copy link
Contributor

ShGKme commented Jun 19, 2024

Rebased onto main and resolved conflicts

@nickvergessen
Copy link
Member

get in? backport?

@Antreesy
Copy link
Contributor Author

get in? backport?

Tested once again, works correctly. Most of the JS code (1 Mb in dev) is loaded after sidebar is opened and DOMContentLoaded, so somewhat a boost. I'm fine with both options

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing feature: frontend 🖌️ "Web UI" client feature: talk-sidebar ⬅️ Sidebar integration of Talk into other apps like sharing and documents performance 🚀
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants