Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(chat): Don't show OOO when it's not appliable #11061

Closed
wants to merge 1 commit into from
Closed

fix(chat): Don't show OOO when it's not appliable #11061

wants to merge 1 commit into from

Conversation

nickvergessen
Copy link
Member

☑️ Resolves

@nickvergessen
fix(chat): Don't show OOO when it's not appliable
6296909 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen self-assigned this Dec 1, 2023
@nickvergessen
Copy link
Member Author

/backport to stable28

@nickvergessen nickvergessen mentioned this pull request Dec 1, 2023
Merged
4 tasks
ChristophWurst
ChristophWurst reviewed Dec 1, 2023
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only works for people with the same timezone offset from UTC

@Antreesy
Copy link
Contributor

Antreesy commented Dec 1, 2023

I'd move it to the store getter, when you decide how to proceed with the server PR

@nickvergessen nickvergessen mentioned this pull request Dec 1, 2023
Merged
@nickvergessen
Copy link
Member Author

Replaced by the applicable /now endpoint in #11062

@Antreesy
Copy link
Contributor

Antreesy commented Dec 5, 2023

Seems to not required anymore with new endpoint

@Antreesy Antreesy closed this Dec 5, 2023
@ChristophWurst ChristophWurst deleted the bugfix/11059/dont-show-ooo-when-not-applicable branch December 5, 2023 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristophWurst ChristophWurst ChristophWurst left review comments

@Antreesy Antreesy Awaiting requested review from Antreesy

Assignees

@nickvergessen nickvergessen

Labels
3. to review bug feature: chat 💬 Chat and system messages feature: frontend 🖌️ "Web UI" client
Projects
None yet
Milestone
v19.0.0-beta.1
Development

Successfully merging this pull request may close these issues.

Only show out of office message when applicable
3 participants
@nickvergessen @Antreesy @ChristophWurst