Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize moment.js locales loading #10338

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Optimize moment.js locales loading #10338

wants to merge 1 commit into from
+433 −5

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Aug 24, 2023

☑️ Resolves

🖼️ Screenshots

🏚️ Before 🏡 After
TODO TODO

🚧 Tasks

  • Ignore all locales by default
  • Add util for importing current user locale
  • Make chunks stored as /js/moment-locales/en.js instead of hundreds of files in root like /js/talk-moment-locale-123.js
  • Make app initialization async to wait for moment.js locales to be loaded before starting the app, or find a way to update locales after loading and re-render the app.

🏁 Checklist

@ShGKme ShGKme self-assigned this Aug 24, 2023
@ShGKme ShGKme marked this pull request as draft August 24, 2023 08:47
@nickvergessen nickvergessen added this to the 💙 Next Major (28) milestone Aug 24, 2023
@Antreesy
Copy link
Contributor

Antreesy commented Aug 29, 2023 •
edited
Loading

Small note on bundle-analyzer:
image

Also output for main.js doesn't show up for me 😢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ShGKme ShGKme

Labels
2. developing feature: frontend 🖌️ "Web UI" client performance 🚀
Projects
None yet
Milestone
🪺 Next Major (32)
Development

Successfully merging this pull request may close these issues.

Do not load all moment locales
4 participants
@ShGKme @Antreesy @nickvergessen @danxuliu