Skip to content

Session expiration is only triggered when the participants are got #4650

Open

Description

Before Talk 9 sessions were expired when the information for a conversation was fetched. Since the introduction of the RoomV2 API fetching the room conversation no longer queries the participants, and thus the sessions are no longer expired in that case. To solve that session expiration was brought back, but only when the clients fetch the participants of a conversation.

This causes that sessions are not properly expired in some cases, for example, in video verification conversations or in public conversations.

How to test (scenario 1)

  • Open the Files app
  • Share a file by link
  • Enable video verification for that link
  • In a private window, open the link
  • Repeat the two steps below until the page is refreshed but leaveRoom is not called
    • Request the password
    • Refresh the page
  • In the original window, open Talk

Expected result

After some time the password request conversation is no longer shown in the conversation list.

Actual result

The password request conversations are kept in the conversation list forever (until the user enters that conversation, then the participants are got and the conversation is destroyed).

How to test (scenario 2)

  • Open Talk
  • Create a public conversation
  • Copy the link
  • Logout
  • Open the link
  • Repeat the three steps below until the window is closed but leaveRoom is not called
    • In a private window, open the link
    • Set a user name
    • Close the private window
  • In the original window, try to mention the other guest

Expected result

After some time the candidate mentions no longer include the guest that left.

Actual result

The guest that left will be shown in the candidate mentions until a user enters the conversation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions