Skip to content

Use a dialog for custom date form instead of including it in the action menu #10202

Open

Description

Including baby forms within action menus is a recurring pattern in Nextcloud and it's one that I think we should break. We shouldn't include forms, especially if they involve multi-selects and pickers, into tiny action menus.
When there's the need of a form we can add an action button that brings up a dialog or opens the form somewhere else.
Having a text input with an inline submit button is probably ok but still not ideal IMO.

In this particular case we have a baby form with a submit button that looks exactly like an action buttons above, creating visual confusion and usability issues. For example here there's no way to guarantee that the picker itself won't block the button to submit the form itself once you've chosen the date. (see screenshot)

This came up in a recent design call and there was some consensus on that we should probably even deprecate these complex action input elements. What do you think @nextcloud/designers ??

Screenshot 2023-08-09 at 17 38 06

Originally posted by @marcoambrosini in #10105 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions