feat(active users): add more active user statistics intervals and improve presentation #691
+104
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcitworld
force-pushed
the
add-more-session-statistics-interval
branch
2 times, most recently
from
bfbf606
to
fab97cb
Compare
This comment was marked as resolved.
This comment was marked as resolved.
tcitworld
force-pushed
the
add-more-session-statistics-interval
branch
2 times, most recently
from
b8ec66b
to
87c8d58
Compare
|
A nice improvement, btw. |
|
Just noticed this drops the 5 minute stat from the UI. Was that intentional? |
I made the choice to not have too many statistics displayed in the UI, and I think it made more sense between 5 minutes and one hour to keep the second one. |
|
I think the "last x" version is nicer. |
|
Thank you, nice enhancement 👍 |
tcitworld
force-pushed
the
add-more-session-statistics-interval
branch
from
87c8d58
to
1e87ff7
Compare
Changed to this. |
tcitworld
force-pushed
the
add-more-session-statistics-interval
branch
from
1e87ff7
to
aad51fe
Compare
tcitworld
requested review from
joshtrichards and
kesselb
and removed request for
kesselb
…rove presentation Signed-off-by: Thomas Citharel <tcit@tcit.fr>
tcitworld
force-pushed
the
add-more-session-statistics-interval
branch
from
aad51fe
to
0342a3c
Compare
jancborchardt
approved these changes
Oct 14, 2024
|
/backport to stable30 |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds:
to the API endpoint.
This view will certainly get converted to Vue at some point (and with proper CSS variables), but it felt like a nice improvement (and to use the new metrics).
Before
After
Full width
Tablet
Large Mobile
Small Mobile