Skip to content

Conversation

kesselb
Copy link
Collaborator

@kesselb kesselb commented Jun 20, 2020

To do:

@kesselb kesselb added this to the Nextcloud 20 milestone Jun 20, 2020
@MorrisJobke MorrisJobke mentioned this pull request Aug 11, 2020
57 tasks
@kesselb kesselb removed this from the Nextcloud 20 milestone Aug 11, 2020
@kesselb kesselb marked this pull request as draft August 11, 2020 10:21
@come-nc
Copy link
Contributor

come-nc commented Mar 31, 2022

@kesselb Is a lot of work left? This looks like a good change which might fix issues.

@kesselb
Copy link
Collaborator Author

kesselb commented Apr 1, 2022

@come-nc I don't remember 🙈

Use memory object

That's about this one: https://github.com/nextcloud/serverinfo/blob/master/lib/Resources/Memory.php

getMemory returns a Memory object now and the above calls needs to be updated.

Update: script.js

I think there is (or was) some normalization logic related to memory in script.js. Not sure what needs to be updated there.

1 similar comment
@kesselb
Copy link
Collaborator Author

kesselb commented Apr 1, 2022

@come-nc I don't remember 🙈

Use memory object

That's about this one: https://github.com/nextcloud/serverinfo/blob/master/lib/Resources/Memory.php

getMemory returns a Memory object now and the above calls needs to be updated.

Update: script.js

I think there is (or was) some normalization logic related to memory in script.js. Not sure what needs to be updated there.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
@come-nc come-nc force-pushed the enh/noid/use-os-get-memory branch from 5a83594 to e6e2dd3 Compare April 4, 2022 06:59
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
Copy link
Contributor

come-nc commented Apr 4, 2022

Note: previous code had a special case handling for using MemFree instead of MemAvailable if MemAvailable is not there because of an older linux kernel. MemAvailable was added in linux 3.14, I guess we do not need support for older kernel than this anymore?

@come-nc come-nc marked this pull request as ready for review April 4, 2022 07:32
@come-nc come-nc requested a review from CarlSchwan April 4, 2022 07:32
@come-nc come-nc merged commit 26d6c2e into master Apr 4, 2022
@delete-merged-branch delete-merged-branch bot deleted the enh/noid/use-os-get-memory branch April 4, 2022 09:40
@kesselb
Copy link
Collaborator Author

kesselb commented Apr 4, 2022

I guess we do not need support for older kernel than this anymore?

Should be fine yes. Linux 3.14 was released in 2014.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants