Skip to content

Make the DELETION of groups match greedy on the groupID #9814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 11, 2018
Merged

Make the DELETION of groups match greedy on the groupID #9814

merged 1 commit into from
Jun 11, 2018

Conversation

@rullzer
Copy link
Member

@rullzer rullzer commented Jun 9, 2018

fixes #6032

Now since the match is greedy it will also eat the /

@rullzer
Make the DELETION of groups match greedy on the groupID
228d1cf 
fixes #6032

Now since the match is greedy it will also eat the /

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzer rullzer added bug 3. to review Waiting for reviews labels Jun 9, 2018
@rullzer rullzer added this to the Nextcloud 14 milestone Jun 9, 2018
@rullzer rullzer mentioned this pull request Jun 9, 2018
Closed
@codecov
Copy link

codecov bot commented Jun 9, 2018 •
edited
Loading

Codecov Report

Merging #9814 into master will increase coverage by <.01%.
The diff coverage is 0%.

@@             Coverage Diff              @@
##             master    #9814      +/-   ##
============================================
+ Coverage     51.92%   51.92%   +<.01%     
  Complexity    25768    25768              
============================================
  Files          1635     1635              
  Lines         95426    95426              
  Branches       1308     1308              
============================================
+ Hits          49548    49552       +4     
+ Misses        45878    45874       -4
Impacted Files Coverage Δ Complexity Δ
apps/provisioning_api/appinfo/routes.php 0% <0%> (ø) 0 <0> (ø) ⬇️
apps/files_trashbin/lib/Expiration.php 90.32% <0%> (-1.62%) 29% <0%> (ø)
core/js/js.js 65.45% <0%> (+0.55%) 0% <0%> (ø) ⬇️

MorrisJobke
MorrisJobke approved these changes Jun 11, 2018
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@MorrisJobke MorrisJobke merged commit cc78e17 into master Jun 11, 2018
@MorrisJobke MorrisJobke deleted the bugfix/6032/delete_group_with_slash branch June 11, 2018 07:42
@MorrisJobke
Copy link
Member

@rullzer Should we backport this?

@rullzer rullzer mentioned this pull request Jun 12, 2018
Merged
@rullzer
Copy link
Member Author

rullzer commented Jun 12, 2018

Yep! simple one liner that fixes a pretty annoying bug so lets do it.

@rullzer rullzer mentioned this pull request Jun 12, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@icewind1991 icewind1991 Awaiting requested review from icewind1991

@blizzz blizzz Awaiting requested review from blizzz

Assignees

No one assigned

Labels

3. to review Waiting for reviews bug

Projects

None yet

Milestone

Nextcloud 14

Development

Successfully merging this pull request may close these issues.

User groups with "/" character in the name can be deleted, but reappear

4 participants

@rullzer @MorrisJobke @skjnldsv