Skip to content

chore: Skip transaction when no preview exists - #65436

Merged
provokateurin merged 1 commit into
masterfrom
chore/noid/skip-transaction-with-no-previews
Oct 13, 2026
Merged

provokateurin merged 1 commit into
masterfrom
chore/noid/skip-transaction-with-no-previews

Conversation

@SystemKeeper

@SystemKeeper SystemKeeper commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

Random finding while looking for something else. No need to start a transaction if we are not doing anything anyway.

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

Assisted-by: ClaudeCode:claude-opus-5-5
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
@SystemKeeper SystemKeeper added this to the Nextcloud 36 milestone Oct 12, 2026
@SystemKeeper SystemKeeper self-assigned this Oct 12, 2026
@SystemKeeper SystemKeeper added 3. to review Waiting for reviews feature: previews and thumbnails php Pull requests that update Php code performance 🚀 labels Oct 12, 2026
@SystemKeeper

Copy link
Copy Markdown
Contributor Author

/backport to stable35

@SystemKeeper
SystemKeeper marked this pull request as ready for review October 12, 2026 18:44
@SystemKeeper
SystemKeeper requested a review from a team as a code owner October 12, 2026 18:44
@SystemKeeper
SystemKeeper requested review from CarlSchwan, leftybournes, provokateurin, salmart-dev and sorbaugh and removed request for a team October 12, 2026 18:44
@CarlSchwan

Copy link
Copy Markdown
Member

/backport to stable34

@provokateurin
provokateurin merged commit 97df9ce into master Oct 13, 2026
257 of 263 checks passed
@provokateurin
provokateurin deleted the chore/noid/skip-transaction-with-no-previews branch October 13, 2026 07:17
@CarlSchwan

Copy link
Copy Markdown
Member

/backport to stable33

@backportbot

backportbot Bot commented Oct 13, 2026

Copy link
Copy Markdown

The backport to stable34 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable34
git pull origin stable34

# Create the new backport branch
git checkout -b backport/65436/stable34

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 08f14193

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/65436/stable34

Error: Failed to create pull request: Validation Failed: {"resource":"PullRequest","code":"custom","message":"A pull request already exists for nextcloud:backport/65436/stable34."} - https://docs.github.com/rest/pulls/pulls#create-a-pull-request


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants