Repository navigation
feat(core): show group restrictions in occ app:list - #64290
GnarlyLion wants to merge 1 commit into
Conversation
Assisted-by: ClaudeCode:claude-sonnet-5 Signed-off-by: GnarlyLion <99709325+GnarlyLion@users.noreply.github.com>
| foreach ($enabledApps as $app) { | ||
| $apps['enabled'][$app] = $versions[$app] ?? true; | ||
| $groups = $this->appManager->getAppRestriction($app); | ||
| if (!empty($groups)) { |
There was a problem hiding this comment.
| if (!empty($groups)) { | |
| if ($groups !== []) { |
| $groups = $this->appManager->getAppRestriction($app); | ||
| if (!empty($groups)) { | ||
| $apps['enabled'][$app] = [ | ||
| 'version' => $versions[$app] ?? true, |
There was a problem hiding this comment.
Hard fail if the version is missing, because it means something is seriously wrong.
| 'groups' => $groups, | ||
| ]; | ||
| } else { | ||
| $apps['enabled'][$app] = $versions[$app] ?? true; |
There was a problem hiding this comment.
This should have the same format as above.
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
This branch has not been deployed
2 participants
Closes #61376
Summary
occ app:list now also shows which groups an app is restricted to, when it's been enabled for specific groups instead of everyone
Checklist
3. to review, feature component)stable32)AI (if applicable)
Claude Code helped write the implementation and test; I reviewed the diff and tested it manually on my own Nextcloud instance.
Assisted-by: ClaudeCode:claude-sonnet-5