libxml - compare against loaded version #612
Conversation
|
nice! please backport |
lib/private/legacy/util.php
Outdated
| version_compare('2.7.0', LIBXML_DOTTED_VERSION) === 1) { | ||
| LIBXML_LOADED_VERSION < 20700 ) { | ||
| $errors[] = array( | ||
| 'error' => $l->t('libxml2 2.7.0 is at least required. Currently %s is installed.', [LIBXML_DOTTED_VERSION]), |
There was a problem hiding this comment.
LOADED version here as well?
There was a problem hiding this comment.
🙈 I didn't noticed that. Yes I will try to get a useful information in a dotted version here.
|
Thanks, work well! only cosmetic - change: complement: sorry, my english is to bad. i hope you understand me |
* if the compiled in version is older than the loaded version Nextcloud doesn't work * uses the loaded libxml version to check against fixes #205
MorrisJobke
force-pushed
the
improve-xml-loaded-version-handling
branch
from
9193334 to
740349f
Compare
|
I fixed the output. |
|
@MorrisJobke |
|
Nasty math 🙈 👍 |
|
🙈 🙊 🙉 |
fixes #205
@kasi45 Could you check your setup with this change? (I slightly modified the check, because in your scenario it luckily worked, but the comparision wasn't correct ;))
@nickvergessen @LukasReschke @rullzer Please review :)
The issue reported needed this to run Nextcloud on an older Qnap system, so I would vote for a backport. @karlitschek