feat: calendar read and write federation

[SebastianKrupinski]

• Resolves: # feature request

Summary

• Requires feat: read calendar ACL properly calendar#7951
• modified federated calendar logic to add write ability
• close Federated calendar and contacts sharing #1440
• documentation feat: federated read/write documentation#14091

Testing

• Federate two instances of NC
• Share a calendar with user from instance A to another user on instance B
• Update a event on instance B in calendar from instance A

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)
• Labels added where applicable (ex: bug/enhancement, 3. to review, feature component)
• Milestone added for target branch/version (ex: 32.x for stable32)

[kesselb]

The failing AppSettingsControllerTest is fixed by #58050

[SebastianKrupinski]

AppSettingsControllerTest

Ty

[SebastianKrupinski]

Up for review will fix psalm in the mean time

[ChristophWurst]

@SebastianKrupinski tell us how this can be tested, please

[SebastianKrupinski]

@SebastianKrupinski tell us how this can be tested, please

Okay, done, updated desciption

[SebastianKrupinski]

@hamza221

* Quitting a share, Unsharing -> don't update for the other user 🚫  (Can be fixed in a followup )

This is done on re-sync, if the request in unauthorized, its removed

* When running sync command with one of the received shared calendars being unshared from the owner (doesn't update because of Point 2 👆🏼)

This was already being caught an handled the original implementation was re throwing the error now we log only

[hamza221]

Notes from Yesterday's test:

• Sharing, Editing privileges, read, Edit: work as expected ✅
• Quitting a share, Unsharing -> don't update for the other user 🚫 (Can be fixed in a followup )
• When running sync command with one of the received shared calendars being unshared from the owner (doesn't update because of Point 2 👆🏼)

Failed to sync calendar f98f0703147a5feeb0180ca9351b1783: Client error: `REPORT http://nextcloud.local/remote.php/dav/remote-calendars/YWRtaW5AaHR0cDovL3N0YWJsZTMzLmxvY2Fs/federated_shared_by_admin``resulted in a``401 Unauthorized` response:
<?xml version="1.0" encoding="utf-8"?>
<d:error xmlns:d="DAV:" xmlns:s="http://sabredav.org/ns">
  <s:exception>Sabre\DA (truncated...) 

Should be fixed or caught and handled

Quitting a share doesn't update for the sharer (Can be fixed in a followup as it doesn't affect any functionality )

[ChristophWurst]

Code looks good

[SebastianKrupinski]

Done. Also added some proper typing on some of the methods

[SebastianKrupinski]

/backport to stable33

[szaimen]

🎉🎉🎉🎉🎉

[SebastianKrupinski]

🎉🎉🎉🎉🎉

I take it this is something you have been waiting for?

[szaimen]

🎉🎉🎉🎉🎉

I take it this is something you have been waiting for?

Yeah, only like 5 years or something 😅

[SebastianKrupinski]

Yeah, only like 5 years or something 😅

🐢 🐢🐢🐢🐢🐢 not 🐰

[tcitworld]

Yeah, only like 5 years or something

5 years ? I have a 10 year-old WIP branch for this 😄
Congrats again for the work.

[rugk]

Federate two instances of NC

I hope it also works when two instances are not explicitly federated, like when sharing files? (You can enter the full user@domain handle there.)

[SebastianKrupinski]

5 years ? I have a 10 year-old WIP branch for this 😄 Congrats again for the work.

Yikes!!!

And thank you