fix(openmetrics): remove superfluous empty lines #57811
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Altahrim
requested review from
ArtificialOwl,
CarlSchwan,
icewind1991 and
sorbaugh
and removed request for
a team
Collaborator
Author
|
/backport to stable33 please |
SystemKeeper
requested changes
Jan 26, 2026
Contributor
SystemKeeper
left a comment
SystemKeeper
left a comment
There was a problem hiding this comment.
I think instead of
# TYPE nextcloud_apps_count gauge
# UNIT nextcloud_apps_count apps
# HELP nextcloud_apps_count Number of apps in Nextcloud
nextcloud_apps_count{status="disabled"} 10
nextcloud_apps_count{status="enabled"} 34
it needs to be
# TYPE nextcloud_apps gauge
# UNIT nextcloud_apps apps
# HELP nextcloud_apps Number of apps in Nextcloud
nextcloud_apps_count{status="disabled"} 10
nextcloud_apps_count{status="enabled"} 34
?
Collaborator
Author
|
I find |
Altahrim
force-pushed
the
fix/openmetrics_exporters
branch
from
ea94197 to
dba083d
Compare
Contributor
sorry |
Collaborator
Author
|
Ah, this one isn't covered by tests… |
Altahrim
force-pushed
the
fix/openmetrics_exporters
branch
from
dba083d to
366d513
Compare
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
Altahrim
force-pushed
the
fix/openmetrics_exporters
branch
from
366d513 to
e81f01e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix issues on OpenMetrics exporter:
Checklist
3. to review, feature component)stable32)