fix(files_external): Respect explicit port configuration #57793
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pac0san
requested review from
icewind1991,
leftybournes,
provokateurin and
salmart-dev
and removed request for
a team
provokateurin
requested changes
Jan 25, 2026
provokateurin
force-pushed
the
patch-1
branch
from
b8c7080 to
79dfb62
Compare
provokateurin
approved these changes
Feb 2, 2026
Member
|
The port field will now take precedence over the port parsed from the host, but the old behavior is still there to avoid breaking changes. |
Member
|
/backport to stable33 |
Member
|
/backport to stable32 |
Member
|
/backport to stable31 |
It allows the use of the alternative SFTP port defined in the GUI (external storage), instead of the default port (22). Signed-off-by: pac0san <7056343+pac0san@users.noreply.github.com> Signed-off-by: provokateurin <kate@provokateurin.de>
provokateurin
force-pushed
the
patch-1
branch
from
79dfb62 to
e48f871
Compare
provokateurin
changed the title
AndyScherzinger
approved these changes
Feb 2, 2026
susnux
approved these changes
Feb 2, 2026
cristianscheid
approved these changes
Feb 2, 2026
|
Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It allows the use of the alternative SFTP port defined in the GUI (external storage), instead of the default port (22).
Summary
TODO
Checklist
3. to review, feature component)stable32)