Skip to content

fix(openmetrics): Allow openmetrics in info.xml #57781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
provokateurin merged 2 commits into from
Jan 26, 2026
Merged

fix(openmetrics): Allow openmetrics in info.xml #57781

provokateurin merged 2 commits into from
Jan 26, 2026

Conversation

@nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Jan 24, 2026 •
edited
Loading

Summary

  • Validate info.xml
  • Make sure a single metrics is also parsed as an array
  • After merge upstream the info.xsd to the appstore and make sure it gets deployed

Checklist

@nickvergessen nickvergessen added this to the Nextcloud 34 milestone Jan 24, 2026
@nickvergessen nickvergessen self-assigned this Jan 24, 2026
@nickvergessen nickvergessen requested a review from a team as a code owner January 24, 2026 12:06
@nickvergessen nickvergessen requested review from come-nc, icewind1991 and provokateurin and removed request for a team January 24, 2026 12:06
@nickvergessen
fix(openmetrics): Allow openmetrics in info.xml
45bae0e 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen force-pushed the bugfix/57766/allow-openmetrics-infoxml branch from c3aa672 to d0c37b2 Compare January 24, 2026 12:12
@SystemKeeper
Copy link
Contributor

SystemKeeper commented Jan 24, 2026 •
edited by AndyScherzinger
Loading

@nickvergessen
fix(openmetrics): Make openmetrics always an array like all other inf…
cc6f49b 
…oxml fields

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen force-pushed the bugfix/57766/allow-openmetrics-infoxml branch from d0c37b2 to cc6f49b Compare January 24, 2026 13:17
@nickvergessen
Copy link
Member Author

nickvergessen commented Jan 24, 2026

/backport to stable33

AndyScherzinger
AndyScherzinger approved these changes Jan 25, 2026
View reviewed changes
Copy link
Member

@AndyScherzinger AndyScherzinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, didn't test.

@provokateurin provokateurin merged commit afe1c1e into master Jan 26, 2026
230 of 243 checks passed
@provokateurin provokateurin deleted the bugfix/57766/allow-openmetrics-infoxml branch January 26, 2026 06:11
@backportbot backportbot bot mentioned this pull request Jan 26, 2026
Merged
@nickvergessen nickvergessen mentioned this pull request Jan 26, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@SystemKeeper SystemKeeper SystemKeeper approved these changes

@provokateurin provokateurin provokateurin approved these changes

@Altahrim Altahrim Awaiting requested review from Altahrim

@icewind1991 icewind1991 Awaiting requested review from icewind1991 icewind1991 is a code owner automatically assigned from nextcloud/server-backend

@come-nc come-nc Awaiting requested review from come-nc come-nc is a code owner automatically assigned from nextcloud/server-backend

Assignees

@nickvergessen nickvergessen

Labels

3. to review Waiting for reviews bug feature: apps management

Projects

None yet

Milestone

Nextcloud 34

Development

Successfully merging this pull request may close these issues.

appinfo.xml schema does not allow openmetrics element

5 participants

@nickvergessen @SystemKeeper @AndyScherzinger @provokateurin