Skip to content

fix(ldap): make base check case insensitive #56080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
hamza221 wants to merge 1 commit into from
Closed

fix(ldap): make base check case insensitive #56080

hamza221 wants to merge 1 commit into from

Conversation

@hamza221
Copy link
Contributor

@hamza221 hamza221 commented Oct 29, 2025

  • Resolves: #

Summary

TODO

  • ...

Checklist

@hamza221
fix(ldap): make base check case insensitive
2c0af45 
Signed-off-by: Hamza <hamzamahjoubi221@gmail.com>
@hamza221 hamza221 requested a review from blizzz October 29, 2025 14:46
@hamza221 hamza221 self-assigned this Oct 29, 2025
@hamza221 hamza221 requested a review from a team as a code owner October 29, 2025 14:46
@hamza221 hamza221 added the 3. to review Waiting for reviews label Oct 29, 2025
@hamza221 hamza221 requested review from ArtificialOwl, leftybournes, salmart-dev and yemkareems and removed request for a team October 29, 2025 14:46
blizzz
blizzz requested changes Oct 29, 2025
View reviewed changes
Copy link
Member

@blizzz blizzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be mb_strtolower as it may contain non-ascii characters.

Imo we still should drop this added checks generally.

To be checked with @come-nc

@blizzz
Copy link
Member

blizzz commented Oct 30, 2025

obsoloted by #56085

@blizzz blizzz closed this Oct 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blizzz blizzz blizzz requested changes

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl is a code owner automatically assigned from nextcloud/server-backend

@salmart-dev salmart-dev Awaiting requested review from salmart-dev salmart-dev is a code owner automatically assigned from nextcloud/server-backend

@yemkareems yemkareems Awaiting requested review from yemkareems yemkareems is a code owner automatically assigned from nextcloud/server-backend

@leftybournes leftybournes Awaiting requested review from leftybournes leftybournes is a code owner automatically assigned from nextcloud/server-backend

Assignees

@hamza221 hamza221

Labels

3. to review Waiting for reviews

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hamza221 @blizzz