Skip to content

[stable31] fix: disable mp3 preview provider #55725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 14, 2025
Merged

[stable31] fix: disable mp3 preview provider #55725

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
15c784d
fix: disable mp3 preview provider
kesselb Oct 9, 2025
ada932f
docs(previews): mp3 preview provider is no longer enabled by default
kesselb Oct 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 7 additions & 10 deletions config/config.sample.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1277,16 +1277,14 @@
/**
* Previews
*
* Nextcloud supports previews of image files, the covers of MP3 files, and text
* files. These options control enabling and disabling previews, and thumbnail
* size.
* Nextcloud supports generating previews for various file types, such as images, audio files, and text files.
* These options control enabling and disabling previews, and thumbnail size.
*/

/**
* By default, Nextcloud can generate previews for the following filetypes:
*
* - Image files
* - Covers of MP3 files
* - Text documents
*
* Valid values are ``true``, to enable previews, or
Expand Down Expand Up @@ -1392,21 +1390,21 @@
* The following providers are disabled by default due to performance or privacy
* concerns:
*
* - ``OC\Preview\EMF``
* - ``OC\Preview\Font``
* - ``OC\Preview\HEIC``
* - ``OC\Preview\Illustrator``
* - ``OC\Preview\Movie``
* - ``OC\Preview\MP3``
* - ``OC\Preview\MSOffice2003``
* - ``OC\Preview\MSOffice2007``
* - ``OC\Preview\MSOfficeDoc``
* - ``OC\Preview\Movie``
* - ``OC\Preview\PDF``
* - ``OC\Preview\Photoshop``
* - ``OC\Preview\Postscript``
* - ``OC\Preview\StarOffice``
* - ``OC\Preview\SVG``
* - ``OC\Preview\StarOffice``
* - ``OC\Preview\TIFF``
* - ``OC\Preview\EMF``
*
*
* Defaults to the following providers:
*
Expand All @@ -1415,19 +1413,18 @@
* - ``OC\Preview\JPEG``
* - ``OC\Preview\Krita``
* - ``OC\Preview\MarkDown``
* - ``OC\Preview\MP3``
* - ``OC\Preview\OpenDocument``
* - ``OC\Preview\PNG``
* - ``OC\Preview\TXT``
* - ``OC\Preview\XBitmap``
*
*/
'enabledPreviewProviders' => [
'OC\Preview\BMP',
'OC\Preview\GIF',
'OC\Preview\JPEG',
'OC\Preview\Krita',
'OC\Preview\MarkDown',
'OC\Preview\MP3',
'OC\Preview\OpenDocument',
'OC\Preview\PNG',
'OC\Preview\TXT',
Expand Down
17 changes: 8 additions & 9 deletions lib/private/PreviewManager.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,29 +251,29 @@ public function isAvailable(\OCP\Files\FileInfo $file, ?string $mimeType = null)
* List of enabled default providers
*
* The following providers are enabled by default:
* - OC\Preview\PNG
* - OC\Preview\JPEG
* - OC\Preview\GIF
* - OC\Preview\BMP
* - OC\Preview\XBitmap
* - OC\Preview\GIF
* - OC\Preview\JPEG
* - OC\Preview\MarkDown
* - OC\Preview\MP3
* - OC\Preview\PNG
* - OC\Preview\TXT
* - OC\Preview\XBitmap
*
* The following providers are disabled by default due to performance or privacy concerns:
* - OC\Preview\Font
* - OC\Preview\HEIC
* - OC\Preview\Illustrator
* - OC\Preview\Movie
* - OC\Preview\MSOfficeDoc
* - OC\Preview\MP3
* - OC\Preview\MSOffice2003
* - OC\Preview\MSOffice2007
* - OC\Preview\MSOfficeDoc
* - OC\Preview\Movie
* - OC\Preview\OpenDocument
* - OC\Preview\PDF
* - OC\Preview\Photoshop
* - OC\Preview\Postscript
* - OC\Preview\StarOffice
* - OC\Preview\SVG
* - OC\Preview\StarOffice
* - OC\Preview\TIFF
*
* @return array
Expand All @@ -295,7 +295,6 @@ protected function getEnabledDefaultProvider() {

$this->defaultProviders = $this->config->getSystemValue('enabledPreviewProviders', array_merge([
Preview\MarkDown::class,
Preview\MP3::class,
Preview\TXT::class,
Preview\OpenDocument::class,
], $imageProviders));
Expand Down
Loading