Skip to content

feat(querybuilder): Remove deprecated IQueryBuilder::execute #55720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 14, 2025
Merged

feat(querybuilder): Remove deprecated IQueryBuilder::execute #55720

merged 1 commit into from
Oct 14, 2025
+0 −59

Conversation

@CarlSchwan
Copy link
Member

@CarlSchwan CarlSchwan commented Oct 13, 2025 •
edited
Loading

This won't work when we update to doctrine DBAL 4 and all usages in server were ported away.

I submitted a bunch of PR to fix some of the apps but apps maintainer should update their app, it's been deprecated for a very long time...

Checklist

@CarlSchwan CarlSchwan added this to the Nextcloud 33 milestone Oct 13, 2025
@CarlSchwan CarlSchwan self-assigned this Oct 13, 2025
@CarlSchwan CarlSchwan added 3. to review Waiting for reviews technical debt pending documentation This pull request needs an associated documentation update labels Oct 13, 2025
@CarlSchwan
feat(querybuilder): Remove deprecated IQueryBuilder::execute
1eff9e5 
This won't work when we update to doctrine DBAL 4 and all usages in
server were ported away.

Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>
@CarlSchwan CarlSchwan force-pushed the carl/remote-querybuilder-execute branch from 275b857 to 1eff9e5 Compare October 13, 2025 15:02
@CarlSchwan CarlSchwan marked this pull request as ready for review October 13, 2025 20:11
@CarlSchwan CarlSchwan requested a review from a team as a code owner October 13, 2025 20:11
@CarlSchwan CarlSchwan requested review from icewind1991, leftybournes and nfebe and removed request for a team October 13, 2025 20:11
@CarlSchwan CarlSchwan merged commit 04a2165 into master Oct 14, 2025
203 of 207 checks passed
@CarlSchwan CarlSchwan deleted the carl/remote-querybuilder-execute branch October 14, 2025 15:19
@mejo- mejo- mentioned this pull request Oct 14, 2025
Merged
@nabim777 nabim777 mentioned this pull request Oct 15, 2025
Merged
8 tasks
@ChristophWurst ChristophWurst mentioned this pull request Oct 15, 2025
Merged
@nickvergessen
Copy link
Member

nickvergessen commented Oct 15, 2025

This must be documented in https://github.com/nextcloud/documentation/blob/0d7f0a97e33107fd1cb4746b1355388f546cf800/developer_manual/app_publishing_maintenance/app_upgrade_guide/upgrade_to_33.rst#removed-apis-1

@kesselb kesselb mentioned this pull request Oct 15, 2025
Merged
@ChristophWurst ChristophWurst mentioned this pull request Oct 16, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@miaulalala miaulalala miaulalala approved these changes

@come-nc come-nc come-nc approved these changes

@icewind1991 icewind1991 Awaiting requested review from icewind1991 icewind1991 is a code owner automatically assigned from nextcloud/server-backend

@nfebe nfebe Awaiting requested review from nfebe nfebe is a code owner automatically assigned from nextcloud/server-backend

@leftybournes leftybournes Awaiting requested review from leftybournes leftybournes is a code owner automatically assigned from nextcloud/server-backend

Assignees

@CarlSchwan CarlSchwan

Labels

3. to review Waiting for reviews pending documentation This pull request needs an associated documentation update technical debt

Projects

None yet

Milestone

Nextcloud 33

Development

Successfully merging this pull request may close these issues.

5 participants

@CarlSchwan @nickvergessen @miaulalala @come-nc