fix(live-photo): Allow files-live-photo meta data with edit permissions #55382
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps
Before
FilesMetadataException(you do not have enough rights to update 'files-live-photo' on this node)is thrown and never catched.{ "reqId": "OpeHNcIfPRVMBJm5AiuZ", "level": 3, "time": "2024-12-18T19:15:48+01:00", "remoteAddr": "9…", "user": "…", "app": "webdav", "method": "PROPPATCH", "url": "/remote.php/dav/files/…/IMG_5573.mov", "message": "you do not have enough rights to update 'files-live-photo' on this node", "userAgent": "Mozilla/5.0 (iOS) Nextcloud-iOS/6.1.9", "version": "30.0.4.1", "exception": { "Exception": "OCP\\FilesMetadata\\Exceptions\\FilesMetadataException", "Message": "you do not have enough rights to update 'files-live-photo' on this node", "Code": 0, "Trace": [ { "file": "/var/www/nextcloud/3rdparty/sabre/dav/lib/DAV/PropPatch.php", "line": 254, "function": "OCA\\DAV\\Connector\\Sabre\\{closure}", "class": "OCA\\DAV\\Connector\\Sabre\\FilesPlugin", "type": "->", "args": [ "*** sensitive parameters replaced ***" ] }, { "file": "/var/www/nextcloud/3rdparty/sabre/dav/lib/DAV/PropPatch.php", "line": 225, "function": "doCallBackSingleProp", "class": "Sabre\\DAV\\PropPatch", "type": "->" }, { "file": "/var/www/nextcloud/3rdparty/sabre/dav/lib/DAV/Server.php", "line": 1264, "function": "commit", "class": "Sabre\\DAV\\PropPatch", "type": "->" }, { "file": "/var/www/nextcloud/3rdparty/sabre/dav/lib/DAV/CorePlugin.php", "line": 373, "function": "updateProperties", "class": "Sabre\\DAV\\Server", "type": "->", "args": [ "*** sensitive parameters replaced ***" ] }, { "file": "/var/www/nextcloud/3rdparty/sabre/event/lib/WildcardEmitterTrait.php", "line": 89, "function": "httpPropPatch", "class": "Sabre\\DAV\\CorePlugin", "type": "->" }, { "file": "/var/www/nextcloud/3rdparty/sabre/dav/lib/DAV/Server.php", "line": 472, "function": "emit", "class": "Sabre\\DAV\\Server", "type": "->" }, { "file": "/var/www/nextcloud/apps/dav/lib/Connector/Sabre/Server.php", "line": 43, "function": "invokeMethod", "class": "Sabre\\DAV\\Server", "type": "->" }, { "file": "/var/www/nextcloud/apps/dav/lib/Server.php", "line": 371, "function": "start", "class": "OCA\\DAV\\Connector\\Sabre\\Server", "type": "->" }, { "file": "/var/www/nextcloud/apps/dav/appinfo/v2/remote.php", "line": 19, "function": "exec", "class": "OCA\\DAV\\Server", "type": "->" }, { "file": "/var/www/nextcloud/remote.php", "line": 146, "args": [ "/var/www/nextcloud/apps/dav/appinfo/v2/remote.php" ], "function": "require_once" } ], "File": "/var/www/nextcloud/apps/dav/lib/Connector/Sabre/FilesPlugin.php", "Line": 589, "message": "you do not have enough rights to update 'files-live-photo' on this node", "exception": {}, "CustomMessage": "you do not have enough rights to update 'files-live-photo' on this node" } }After
Write permissions is enough => upload works 207
Checklist
3. to review, feature component)stable32)