Skip to content

Conversation

@nickvergessen
Copy link
Member

Steps

  • Have a folder received as share
  • Enable iOS auto upload to that folder
  • Disable iOS auto upload
  • Enable iOS auto upload again

Before

  • FilesMetadataException(you do not have enough rights to update 'files-live-photo' on this node) is thrown and never catched.
  • WebDAV responds with 500
  • Auto upload is paused for 20 minutes to not DOS the server in case of a temporary error
  • result: Uploading 24k items with autoupload takes 8000 hours = 333 days
{
  "reqId": "OpeHNcIfPRVMBJm5AiuZ",
  "level": 3,
  "time": "2024-12-18T19:15:48+01:00",
  "remoteAddr": "9…",
  "user": "",
  "app": "webdav",
  "method": "PROPPATCH",
  "url": "/remote.php/dav/files/…/IMG_5573.mov",
  "message": "you do not have enough rights to update 'files-live-photo' on this node",
  "userAgent": "Mozilla/5.0 (iOS) Nextcloud-iOS/6.1.9",
  "version": "30.0.4.1",
  "exception": {
    "Exception": "OCP\\FilesMetadata\\Exceptions\\FilesMetadataException",
    "Message": "you do not have enough rights to update 'files-live-photo' on this node",
    "Code": 0,
    "Trace": [
      {
        "file": "/var/www/nextcloud/3rdparty/sabre/dav/lib/DAV/PropPatch.php",
        "line": 254,
        "function": "OCA\\DAV\\Connector\\Sabre\\{closure}",
        "class": "OCA\\DAV\\Connector\\Sabre\\FilesPlugin",
        "type": "->",
        "args": [
          "*** sensitive parameters replaced ***"
        ]
      },
      {
        "file": "/var/www/nextcloud/3rdparty/sabre/dav/lib/DAV/PropPatch.php",
        "line": 225,
        "function": "doCallBackSingleProp",
        "class": "Sabre\\DAV\\PropPatch",
        "type": "->"
      },
      {
        "file": "/var/www/nextcloud/3rdparty/sabre/dav/lib/DAV/Server.php",
        "line": 1264,
        "function": "commit",
        "class": "Sabre\\DAV\\PropPatch",
        "type": "->"
      },
      {
        "file": "/var/www/nextcloud/3rdparty/sabre/dav/lib/DAV/CorePlugin.php",
        "line": 373,
        "function": "updateProperties",
        "class": "Sabre\\DAV\\Server",
        "type": "->",
        "args": [
          "*** sensitive parameters replaced ***"
        ]
      },
      {
        "file": "/var/www/nextcloud/3rdparty/sabre/event/lib/WildcardEmitterTrait.php",
        "line": 89,
        "function": "httpPropPatch",
        "class": "Sabre\\DAV\\CorePlugin",
        "type": "->"
      },
      {
        "file": "/var/www/nextcloud/3rdparty/sabre/dav/lib/DAV/Server.php",
        "line": 472,
        "function": "emit",
        "class": "Sabre\\DAV\\Server",
        "type": "->"
      },
      {
        "file": "/var/www/nextcloud/apps/dav/lib/Connector/Sabre/Server.php",
        "line": 43,
        "function": "invokeMethod",
        "class": "Sabre\\DAV\\Server",
        "type": "->"
      },
      {
        "file": "/var/www/nextcloud/apps/dav/lib/Server.php",
        "line": 371,
        "function": "start",
        "class": "OCA\\DAV\\Connector\\Sabre\\Server",
        "type": "->"
      },
      {
        "file": "/var/www/nextcloud/apps/dav/appinfo/v2/remote.php",
        "line": 19,
        "function": "exec",
        "class": "OCA\\DAV\\Server",
        "type": "->"
      },
      {
        "file": "/var/www/nextcloud/remote.php",
        "line": 146,
        "args": [
          "/var/www/nextcloud/apps/dav/appinfo/v2/remote.php"
        ],
        "function": "require_once"
      }
    ],
    "File": "/var/www/nextcloud/apps/dav/lib/Connector/Sabre/FilesPlugin.php",
    "Line": 589,
    "message": "you do not have enough rights to update 'files-live-photo' on this node",
    "exception": {},
    "CustomMessage": "you do not have enough rights to update 'files-live-photo' on this node"
  }
}

After

Write permissions is enough => upload works 207

Checklist

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added this to the Nextcloud 33 milestone Sep 28, 2025
@nickvergessen nickvergessen self-assigned this Sep 28, 2025
@nickvergessen nickvergessen requested a review from a team as a code owner September 28, 2025 15:39
@artonge
Copy link
Contributor

artonge commented Sep 29, 2025

Let's wait for @ArtificialOwl 🙏

Copy link
Member

@ArtificialOwl ArtificialOwl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make senses

@nickvergessen nickvergessen merged commit d6cafee into master Oct 7, 2025
194 of 198 checks passed
@nickvergessen nickvergessen deleted the bugfix/noid/files-live-photo-permission branch October 7, 2025 18:55
@nickvergessen
Copy link
Member Author

/backport to stable32

@nickvergessen
Copy link
Member Author

/backport to stable31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants