feat(OCM-Invites): Enable the invitesAcceptedDialog#55182
feat(OCM-Invites): Enable the invitesAcceptedDialog#55182mickenordin wants to merge 2 commits intonextcloud:masterfrom
Conversation
If the contacts app has enabled OCM invites, we need to show that in the discovery. Signed-off-by: Micke Nordin <kano@sunet.se>
|
/backport to stable32 |
|
Hello Micke, with the release of nc32 in few days, I though it would be easier for everyone to make a new PR including your work, and a slightly better way to implements the feature. The idea is to let 'contacts' app to enable the feature and set the correct route to the feature instead of hard written in code: I hope you're fine with it ! |
|
With @ArtificialOwl's patch, this is no longer needed, so closing. |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
In a previous pr: #51113 the necessary plumbing for OCM Invites was introduced.
Now the companion PR for the contacts is coming along nicely: nextcloud/contacts#4417 and that means that we should now display the inviteAcceptDialog that is provided from the contacts app according to the specification: https://www.ietf.org/archive/id/draft-lopresti-open-cloud-mesh-05.html#name-fields
We can only do that in core, since that is where OCM discovery lives, so here is a PR for that.
TL;DR; If the contacts app has enabled OCM invites, we need to show that in the discovery.