[stable30] fix(Apps): fix install command check on existing apps #55065
+4
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
otoh not sure whether this approach might cause other side effects, as UPDATE: |
- AppManager::isInstalled() is misleading, as it checks only whether it is enabled. But an app might not be present in some edge cases. - AppManager::getAppPath() does however only check whether an app dir is present, independent of the enabled-state. Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
blizzz
force-pushed
the
fix/noid/return-actually-installed-apps-stable30
branch
from
8e06240 to
ac6653e
Compare
blizzz
changed the title
blizzz
added a commit
to nextcloud/univention-app
that referenced
this pull request
Sep 12, 2025
- includes nextcloud/server#55065 Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
6 tasks
blizzz
added a commit
to nextcloud/univention-app
that referenced
this pull request
Sep 12, 2025
- includes nextcloud/server#55065 Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
come-nc
reviewed
Sep 15, 2025
No, you run |
come-nc
approved these changes
Sep 29, 2025
blizzz
added
3. to review
blizzz
requested review from
a team,
ArtificialOwl,
CarlSchwan and
provokateurin
and removed request for
a team
provokateurin
approved these changes
Sep 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently, enabled apps are returned, whether they are installed or not. This is a behavioral breaking change compared to 29.
Based this now on 30 for nextcloud/univention-app#208, and I am not sure this is what we really want in server (cf. my comment at https://github.com/nextcloud/server/pull/49648/files#r2341962849).
If so, I'd do a new PR based on master, which has diverges further.
Checklist