Skip to content

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Sep 1, 2025

Summary

We need to provide an API that does not rely on Vue.
As Vue components must not be shared between different apps.

Checklist

@susnux susnux added this to the Nextcloud 32 milestone Sep 1, 2025
susnux added a commit to nextcloud/files_downloadlimit that referenced this pull request Sep 1, 2025
* Based on nextcloud/server#50783
* For #514
  * Server companion: nextcloud/server#54788
  * Library companion: nextcloud-libraries/nextcloud-sharing#95

We  need to provide an API that does not rely on Vue.
As Vue components **must not** be shared between different apps.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux force-pushed the feat/sharing-node-api branch 2 times, most recently from b593f93 to 25e8466 Compare September 5, 2025 11:28
@susnux susnux marked this pull request as ready for review September 5, 2025 11:29
@susnux susnux requested review from a team and skjnldsv as code owners September 5, 2025 11:29
@susnux susnux requested review from CarlSchwan, artonge, nfebe and sorbaugh and removed request for a team and nfebe September 5, 2025 11:29
@susnux susnux requested review from nfebe and st3iny and removed request for sorbaugh September 11, 2025 10:43
@susnux
Copy link
Contributor Author

susnux commented Sep 11, 2025

/backport to stable32

@susnux
Copy link
Contributor Author

susnux commented Sep 11, 2025

/backport to stable31

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
This fixes apps providing vue components, which is invalid and does not
always work - and never work with Vue 3.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@CarlSchwan CarlSchwan force-pushed the feat/sharing-node-api branch from 25e8466 to ee962f3 Compare September 18, 2025 13:45
@CarlSchwan
Copy link
Member

/compile rebase

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@CarlSchwan CarlSchwan merged commit 809d87c into master Sep 18, 2025
126 checks passed
@CarlSchwan CarlSchwan deleted the feat/sharing-node-api branch September 18, 2025 14:11
Copy link

backportbot bot commented Sep 18, 2025

The backport to stable31 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable31
git pull origin stable31

# Create the new backport branch
git checkout -b backport/54788/stable31

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 931247f9 c5a093d8 ee962f3a 41a46c59

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/54788/stable31

Error: Failed to push branch backport/54788/stable31: remote: {"auth_status":"auth_error","body":"Invalid username or token. Password authentication is not supported for Git operations."}
fatal: Authentication failed for 'https://github.com/nextcloud/server.git/'


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

CarlSchwan pushed a commit to nextcloud/files_downloadlimit that referenced this pull request Sep 18, 2025
* Based on nextcloud/server#50783
* For #514
  * Server companion: nextcloud/server#54788
  * Library companion: nextcloud-libraries/nextcloud-sharing#95

We  need to provide an API that does not rely on Vue.
As Vue components **must not** be shared between different apps.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>
CarlSchwan pushed a commit to nextcloud/files_downloadlimit that referenced this pull request Sep 19, 2025
* Based on nextcloud/server#50783
* For #514
  * Server companion: nextcloud/server#54788
  * Library companion: nextcloud-libraries/nextcloud-sharing#95

We  need to provide an API that does not rely on Vue.
As Vue components **must not** be shared between different apps.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>
backportbot bot pushed a commit to nextcloud/files_downloadlimit that referenced this pull request Sep 19, 2025
* Based on nextcloud/server#50783

* For #514

* Server companion: nextcloud/server#54788

* Library companion: nextcloud-libraries/nextcloud-sharing#95

We  need to provide an API that does not rely on Vue.

As Vue components **must not** be shared between different apps.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>

[skip ci]
susnux added a commit to nextcloud/files_downloadlimit that referenced this pull request Sep 24, 2025
* Based on nextcloud/server#50783
* For #514
  * Server companion: nextcloud/server#54788
  * Library companion: nextcloud-libraries/nextcloud-sharing#95

We  need to provide an API that does not rely on Vue.
As Vue components **must not** be shared between different apps.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>
susnux added a commit to nextcloud/files_downloadlimit that referenced this pull request Sep 24, 2025
* Based on nextcloud/server#50783
* For #514
  * Server companion: nextcloud/server#54788
  * Library companion: nextcloud-libraries/nextcloud-sharing#95

We  need to provide an API that does not rely on Vue.
As Vue components **must not** be shared between different apps.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>
@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants