[stable30] fix: use the join function for merging davRootPath and path #54382
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skjnldsv
approved these changes
Aug 12, 2025
susnux
approved these changes
Aug 12, 2025
|
Will add the milestone again, once 30.0.14 is out. |
Using the join function ensures, that also paths without a leading slash a properly merged together. Extracted from 3978e05. Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
kesselb
force-pushed
the
bug/noid/jump-to-files-empty-file-list-30
branch
from
23e4602 to
16c57a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Using the join function ensures, that also paths without a leading slash
a properly merged together. Extracted from 3978e05.
That change only ensures we are still rending the files list, but does not address the problem with opening/scrolling to the selected file: #54378.
TODO
Checklist