Skip to content

feat(mounts): optimize load of mounts by filtering on database side #54197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 26, 2025
Merged

feat(mounts): optimize load of mounts by filtering on database side #54197

merged 1 commit into from
Aug 26, 2025

Conversation

@Altahrim
Copy link
Collaborator

@Altahrim Altahrim commented Aug 1, 2025

Filters mounts on database side to free some database bandwidth

@Altahrim Altahrim added this to the Nextcloud 32 milestone Aug 1, 2025
@Altahrim Altahrim self-assigned this Aug 1, 2025
@Altahrim Altahrim force-pushed the perf/reduce_mount_db_load branch 2 times, most recently from 9af0815 to 6d38980 Compare August 1, 2025 14:05
@icewind1991
Copy link
Member

related: #51074

@Altahrim Altahrim force-pushed the perf/reduce_mount_db_load branch from 6d38980 to 6dca476 Compare August 1, 2025 14:30
@Altahrim Altahrim marked this pull request as ready for review August 4, 2025 07:53
@Altahrim Altahrim requested a review from a team as a code owner August 4, 2025 07:53
@Altahrim Altahrim requested review from ArtificialOwl, CarlSchwan and sorbaugh and removed request for a team August 4, 2025 07:53
@Altahrim Altahrim added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Aug 4, 2025
salmart-dev
salmart-dev reviewed Aug 4, 2025
View reviewed changes
Copy link
Contributor

@salmart-dev salmart-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I see, the query in getMountsForStorageId has been inlined in this function and extended it with the rules that were previously filtering the rows in PHP.

nickvergessen
nickvergessen reviewed Aug 5, 2025
View reviewed changes
@Altahrim Altahrim force-pushed the perf/reduce_mount_db_load branch from 6333c81 to ef204ec Compare August 5, 2025 08:38
@Altahrim Altahrim force-pushed the perf/reduce_mount_db_load branch from ef204ec to 8edae4b Compare August 12, 2025 12:01
icewind1991
icewind1991 reviewed Aug 14, 2025
View reviewed changes
This was referenced Aug 22, 2025
Merged
Merged
@Altahrim
feat(mounts): optimize load of mounts by filtering on database side
39e2e70 
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
@Altahrim Altahrim force-pushed the perf/reduce_mount_db_load branch from b98479a to 39e2e70 Compare August 26, 2025 06:55
@Altahrim Altahrim enabled auto-merge August 26, 2025 07:54
@Altahrim Altahrim merged commit 7c8c593 into master Aug 26, 2025
205 of 207 checks passed
@Altahrim Altahrim deleted the perf/reduce_mount_db_load branch August 26, 2025 11:53
@nickvergessen nickvergessen mentioned this pull request Aug 27, 2025
Merged
3 tasks
@nextcloud-bot nextcloud-bot mentioned this pull request Aug 28, 2025
Merged
@nickvergessen nickvergessen mentioned this pull request Aug 28, 2025
Closed
@icewind1991 icewind1991 mentioned this pull request Aug 29, 2025
Merged
@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessen nickvergessen nickvergessen left review comments

@icewind1991 icewind1991 icewind1991 approved these changes

@salmart-dev salmart-dev salmart-dev approved these changes

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl is a code owner automatically assigned from nextcloud/server-backend

@CarlSchwan CarlSchwan Awaiting requested review from CarlSchwan CarlSchwan is a code owner automatically assigned from nextcloud/server-backend

@sorbaugh sorbaugh Awaiting requested review from sorbaugh sorbaugh is a code owner automatically assigned from nextcloud/server-backend

Assignees

@Altahrim Altahrim

Labels

3. to review Waiting for reviews performance 🚀

Projects

None yet

Milestone

Nextcloud 32

Development

Successfully merging this pull request may close these issues.

6 participants

@Altahrim @icewind1991 @nickvergessen @salmart-dev @skjnldsv