Skip to content

[stable31] fix(session): log when ephemeral sessions are closed #54106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 1, 2025
Merged

[stable31] fix(session): log when ephemeral sessions are closed #54106

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions lib/private/AppFramework/Middleware/FlowV2EphemeralSessionsMiddleware.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
use OCP\AppFramework\Middleware;
use OCP\ISession;
use OCP\IUserSession;
use Psr\Log\LoggerInterface;
use ReflectionMethod;

// Will close the session if the user session is ephemeral.
Expand All @@ -24,6 +25,7 @@ public function __construct(
private ISession $session,
private IUserSession $userSession,
private ControllerMethodReflector $reflector,
private LoggerInterface $logger,
) {
}

Expand Down Expand Up @@ -52,6 +54,10 @@ public function beforeController(Controller $controller, string $methodName) {
return;
}

$this->logger->info('Closing user and PHP session for ephemeral session', [
'controller' => $controller::class,
'method' => $methodName,
]);
$this->userSession->logout();
$this->session->close();
}
Expand Down
Loading