fix(ConnectionFactory): Apply Oracle connection fix to primary and replica params as well #54027
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…plica params as well Signed-off-by: Marcel Klehr <mklehr@gmx.net>
marcelklehr
requested review from
Altahrim,
leftybournes and
provokateurin
and removed request for
a team
|
/backport to stable31 |
|
/backport to stable30 |
|
/backport to stable29 |
nickvergessen
added
bug
3. to review
|
Customer confirms the patch is working. |
nickvergessen
approved these changes
Jul 23, 2025
nickvergessen
requested review from
ChristophWurst and
icewind1991
and removed request for
leftybournes
This was referenced Jul 28, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The ConnectionFactory code applies some array plumbing to make Doctrine connect to Oracle for some reason. Since nc 29, we also have primary and replica entries, however, where this plumbing also needs to be applied.
Checklist