Skip to content

fix(files): sort favorites navigation alphabetically #53967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 23, 2025
Merged

fix(files): sort favorites navigation alphabetically #53967

merged 2 commits into from
Jul 23, 2025

Conversation

@skjnldsv
Copy link
Member

Summary

We used to sort by path, it's now sorted alphabetically

Before After
2025-07-16_09-09 2025-07-16_09-08

Checklist

@skjnldsv skjnldsv added this to the Nextcloud 32 milestone Jul 16, 2025
@skjnldsv skjnldsv self-assigned this Jul 16, 2025
@skjnldsv skjnldsv requested a review from a team as a code owner July 16, 2025 07:10
@skjnldsv skjnldsv added bug 3. to review Waiting for reviews labels Jul 16, 2025
@skjnldsv skjnldsv requested review from nfebe and susnux and removed request for a team July 16, 2025 07:10
@skjnldsv skjnldsv requested a review from szaimen July 16, 2025 07:10
@skjnldsv
Copy link
Member Author

skjnldsv commented Jul 16, 2025 •
edited
Loading

/backport 9d7214b to stable31

@skjnldsv
Copy link
Member Author

skjnldsv commented Jul 16, 2025 •
edited
Loading

/backport 9d7214b to stable30

szaimen
szaimen approved these changes Jul 17, 2025
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from the screenshot :)

@skjnldsv
Copy link
Member Author

/compile rebase

@nextcloud-command nextcloud-command requested a review from a team as a code owner July 17, 2025 12:30
@skjnldsv

This comment was marked as resolved.

Sign in to view
@skjnldsv skjnldsv added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Jul 17, 2025
skjnldsv added 2 commits July 23, 2025 10:15
@skjnldsv
fix(files): sort favorites navigation alphabetically
9d7214b 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
@skjnldsv
chore(assets): Recompile assets
6d3ad08 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 2. developing Work in progress labels Jul 23, 2025
@skjnldsv skjnldsv merged commit cf29ebb into master Jul 23, 2025
131 of 136 checks passed
@skjnldsv skjnldsv deleted the fix/fav-sort-nav branch July 23, 2025 13:28
This was referenced Jul 23, 2025
Merged
Merged
@skjnldsv skjnldsv mentioned this pull request Aug 19, 2025
Merged
@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@susnux susnux susnux approved these changes

@szaimen szaimen szaimen approved these changes

@nfebe nfebe Awaiting requested review from nfebe nfebe is a code owner automatically assigned from nextcloud/server-frontend

Assignees

@skjnldsv skjnldsv

Labels

4. to release Ready to be released and/or waiting for tests to finish bug feature: files

Projects

None yet

Milestone

Nextcloud 32

Development

Successfully merging this pull request may close these issues.

Files Favorites Dropdown should be sorted alphabetically

3 participants

@skjnldsv @susnux @szaimen