fix: force lowercase emails

[skjnldsv]

Summary

• Resolves: [Bug]: Uppercase Letters in Email Addresses Cause Login and Email Delivery Issues #53367

Not 100% sure this is the best in terms of code quality, but seems the most straightforward 🤷

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

[provokateurin]

Technically wrong, accepted in reality 🤷‍♀️

[come-nc]

This is enough, you do not need to add calls to mb_strtolower prior to calling this method, no?
Feels like you added the conversion both outside and inside of the setter. Inside is enough IMO

[skjnldsv]

Yes, it's because the email/value is sometimes also used at later stages of the parent methods.
So the setter is nice, but not enough

[skjnldsv]

/backport to stable31

[skjnldsv]

/backport to stable30

[provokateurin]

The psalm baseline was not adjusted:

ERROR: UnusedBaselineEntry
at :0:0
Baseline for issue "DeprecatedMethod" has 1 extra entry. (see https://psalm.dev/316)

PR will follow in a few seconds.

[skjnldsv]

The psalm baseline was not adjusted:

ERROR: UnusedBaselineEntry
at :0:0
Baseline for issue "DeprecatedMethod" has 1 extra entry. (see https://psalm.dev/316)

PR will follow in a few seconds.

Weird, it didn't complain on CI and I did run a baseline update (you can see it in the changed files)
What should I have done to catch this?

[provokateurin]

I'm not sure either, it's a bit weird. I think it might just be psalm doing weird things again.

[unvermuthet]

Does this fix #53367 if I have existing users with capitalized mail addresses?

[skjnldsv]

Does this fix #53367 if I have existing users with capitalized mail addresses?

I think it should, we'll be happy to have some feedback if you can try the RC1 releases of yesterday :)