fix(federatedfilesharing): Fix external share being deleted when accepting share

[provokateurin]

• Resolves: [Bug]: Federated Share gets deleted on acceptance by the receiving user #52928

Summary

server/apps/federatedfilesharing/src/services/dialogService.ts

Line 29 in d3dd428

resolve(undefined)

returns undefined as a "good" state, but the check later is risky and results in a true which then deletes the share.

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

[provokateurin]

/backport to stable31

[provokateurin]

/backport to stable30

[provokateurin]

/compile

[MahdiBaghbani]

@provokateurin I believe that the #52931 is no longer necessary, am I correct?

[provokateurin]

That's correct. I didn't notice that there already was a PR for fixing this.

[backportbot]

The backport to stable30 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable30
git pull origin stable30

# Create the new backport branch
git checkout -b backport/53840/stable30

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 6a3a5146 fed2c46b

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/53840/stable30

Error: Failed to check for changes with origin/stable30: No changes found in backport branch

---

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.