Skip to content

Conversation

@skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Jul 4, 2025

A bit of a change on the logic, this will help #53739

  1. Instead of rendering empty contents and error messages outside the FilesList, thus unmounting it, we inject the content as a slot
  2. We provide a dummy root Folder in case we don't have a cached root one
  3. We remove the duplicate FilesListHeader logic
  4. We ensure FilesListHeaders are always mounted thus avoiding issues when destroying/mounting it again, and we improve the overall performances
  5. Adds a redirect after page is done loading in case the url doesn't match a valid View. This is a weird edge case, but I figured it would be clean to have. E.G, try accessing https://dev.domain.com/apps/files/FAKEVIEW

@skjnldsv skjnldsv added this to the Nextcloud 32 milestone Jul 4, 2025
@skjnldsv skjnldsv requested a review from susnux July 4, 2025 14:18
@skjnldsv skjnldsv self-assigned this Jul 4, 2025
@skjnldsv skjnldsv requested a review from a team as a code owner July 4, 2025 14:18
@skjnldsv skjnldsv added enhancement 3. to review Waiting for reviews labels Jul 4, 2025
@skjnldsv skjnldsv requested review from szaimen and removed request for a team July 4, 2025 14:18
@skjnldsv skjnldsv requested a review from sorbaugh July 4, 2025 14:18
@skjnldsv

This comment was marked as resolved.

@nextcloud-command nextcloud-command requested a review from a team as a code owner July 4, 2025 14:26
@skjnldsv skjnldsv force-pushed the fix/FileList-render branch from e077725 to 3b0e47c Compare July 4, 2025 14:44
@skjnldsv skjnldsv requested a review from susnux July 4, 2025 14:45
@susnux susnux force-pushed the fix/FileList-render branch from 3b0e47c to 24b59de Compare July 4, 2025 16:38
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased onto new default view feature

@susnux susnux requested review from nfebe and removed request for a team July 4, 2025 16:41
@skjnldsv skjnldsv force-pushed the fix/FileList-render branch 2 times, most recently from 009509b to a74a269 Compare July 4, 2025 18:40
@skjnldsv skjnldsv force-pushed the fix/FileList-render branch from 476ecd4 to e803366 Compare July 7, 2025 08:49
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@susnux susnux force-pushed the fix/FileList-render branch from e803366 to 8645924 Compare July 7, 2025 10:06
@skjnldsv
Copy link
Member Author

skjnldsv commented Jul 7, 2025

@susnux something needs a fix on the scrolling tests 🤔
I'm still investigating :)

@skjnldsv skjnldsv force-pushed the fix/FileList-render branch from 8645924 to 8ca213b Compare July 7, 2025 10:30
@skjnldsv skjnldsv force-pushed the fix/FileList-render branch from 8ca213b to fb62c4f Compare July 7, 2025 10:56
skjnldsv and others added 3 commits July 8, 2025 09:13
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
…ils or openfile

Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
@skjnldsv skjnldsv force-pushed the fix/FileList-render branch from b4d6364 to b1c9c45 Compare July 8, 2025 07:16
skjnldsv added 2 commits July 8, 2025 09:23
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
@skjnldsv skjnldsv force-pushed the fix/FileList-render branch from b1c9c45 to 47b2a96 Compare July 8, 2025 07:23
@skjnldsv skjnldsv enabled auto-merge July 8, 2025 07:59
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jul 8, 2025
@skjnldsv skjnldsv merged commit 58e1427 into master Jul 8, 2025
134 of 136 checks passed
@skjnldsv skjnldsv deleted the fix/FileList-render branch July 8, 2025 08:09
max-nextcloud added a commit to nextcloud/text that referenced this pull request Jul 8, 2025
Decompose SyncService

Cypress failure is unrelated (happening since nextcloud/server#53824 ).
@skjnldsv skjnldsv mentioned this pull request Aug 19, 2025
@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants