-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
fix(files): make sure the FilesList is always mounted #53824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
susnux
reviewed
Jul 4, 2025
susnux
reviewed
Jul 4, 2025
e077725 to
3b0e47c
Compare
3b0e47c to
24b59de
Compare
susnux
approved these changes
Jul 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rebased onto new default view feature
009509b to
a74a269
Compare
susnux
approved these changes
Jul 4, 2025
476ecd4 to
e803366
Compare
szaimen
approved these changes
Jul 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🐘
e803366 to
8645924
Compare
|
@susnux something needs a fix on the scrolling tests 🤔 |
8645924 to
8ca213b
Compare
8ca213b to
fb62c4f
Compare
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
…ils or openfile Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
b4d6364 to
b1c9c45
Compare
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
b1c9c45 to
47b2a96
Compare
max-nextcloud
added a commit
to nextcloud/text
that referenced
this pull request
Jul 8, 2025
Decompose SyncService Cypress failure is unrelated (happening since nextcloud/server#53824 ).
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
4. to release
Ready to be released and/or waiting for tests to finish
developer experience
enhancement
feature: files
technical debt
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bit of a change on the logic, this will help #53739