-
-
Couldn't load subscription status.
- Fork 4.6k
fix: Correctly show free space if lower than quota in Files navigation #53693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/backport to stable31 |
|
/compile / |
|
/backport to stable30 |
skjnldsv
approved these changes
Jun 26, 2025
8 tasks
|
I broke it I think 🙈 |
Ah, no, the test needs fixing, it mocks an incomplete server answer |
susnux
approved these changes
Jul 3, 2025
fae8d66 to
be10a5b
Compare
|
/compile / |
|
(rebased because frontend conflicts, recompiling) |
|
|
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Mocked server initial state was incomplete Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
fc7f96b to
fed1451
Compare
|
/compile / |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
This was referenced Jul 3, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This fixes an inconsistency between files navigation and user personal settings.
Files navigation was incorrectly showing full quota even if the actual free space on disk is lower. The percentage shown is relative to free space in this case, so that is what should be shown as maximum in the UI.
When no quota is set, no maximum or percentage is shown, as before this PR.
Checklist