Skip to content

Conversation

@come-nc
Copy link
Contributor

@come-nc come-nc commented Jun 26, 2025

Summary

This fixes an inconsistency between files navigation and user personal settings.
Files navigation was incorrectly showing full quota even if the actual free space on disk is lower. The percentage shown is relative to free space in this case, so that is what should be shown as maximum in the UI.

When no quota is set, no maximum or percentage is shown, as before this PR.

Checklist

@come-nc come-nc added this to the Nextcloud 32 milestone Jun 26, 2025
@come-nc come-nc self-assigned this Jun 26, 2025
@come-nc come-nc requested a review from skjnldsv as a code owner June 26, 2025 08:58
@come-nc come-nc added the 3. to review Waiting for reviews label Jun 26, 2025
@come-nc come-nc requested a review from a team as a code owner June 26, 2025 08:58
@come-nc come-nc requested review from artonge and sorbaugh and removed request for a team June 26, 2025 08:58
@come-nc
Copy link
Contributor Author

come-nc commented Jun 26, 2025

/backport to stable31

@come-nc
Copy link
Contributor Author

come-nc commented Jun 26, 2025

/compile /

@come-nc
Copy link
Contributor Author

come-nc commented Jun 26, 2025

/backport to stable30

@nextcloud-command nextcloud-command requested a review from a team as a code owner June 26, 2025 09:06
@come-nc
Copy link
Contributor Author

come-nc commented Jun 26, 2025

I broke it I think 🙈

  1) Quota rendering
       Non-reached quota:

      Timed out retrying after 4000ms
      + expected - actual

      -' 1 GB of NaN B used '
      +'1 GB of 5 GB used'

@come-nc
Copy link
Contributor Author

come-nc commented Jun 26, 2025

I broke it I think 🙈

  1) Quota rendering
       Non-reached quota:

      Timed out retrying after 4000ms
      + expected - actual

      -' 1 GB of NaN B used '
      +'1 GB of 5 GB used'

Ah, no, the test needs fixing, it mocks an incomplete server answer

@come-nc come-nc requested a review from susnux July 3, 2025 14:54
@come-nc come-nc force-pushed the fix/files-navigation-quota-total branch from fae8d66 to be10a5b Compare July 3, 2025 14:57
@come-nc
Copy link
Contributor Author

come-nc commented Jul 3, 2025

/compile /

@come-nc
Copy link
Contributor Author

come-nc commented Jul 3, 2025

(rebased because frontend conflicts, recompiling)

@come-nc
Copy link
Contributor Author

come-nc commented Jul 3, 2025

This branch has conflicts that must be resolved (╯°□°)╯︵ ┻━┻

come-nc added 2 commits July 3, 2025 17:44
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Mocked server initial state was incomplete

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc come-nc force-pushed the fix/files-navigation-quota-total branch from fc7f96b to fed1451 Compare July 3, 2025 15:45
@come-nc
Copy link
Contributor Author

come-nc commented Jul 3, 2025

/compile /

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@come-nc come-nc enabled auto-merge July 3, 2025 15:54
@come-nc come-nc added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jul 3, 2025
@come-nc come-nc merged commit b880ec3 into master Jul 3, 2025
124 checks passed
@come-nc come-nc deleted the fix/files-navigation-quota-total branch July 3, 2025 16:13
@skjnldsv skjnldsv mentioned this pull request Aug 19, 2025
@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish feature: files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Invalid quota value on user's profile page

4 participants