Skip to content

fix(dav): catch exception on non local account #53677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 25, 2025
+8 −1
Merged

fix(dav): catch exception on non local account #53677

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion apps/dav/lib/Connector/Sabre/FilesPlugin.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@

use OC\AppFramework\Http\Request;
use OC\FilesMetadata\Model\FilesMetadata;
use OC\User\NoUserException;
use OCA\DAV\Connector\Sabre\Exception\InvalidPath;
use OCA\Files_Sharing\External\Mount as SharingExternalMount;
use OCP\Accounts\IAccountManager;
Expand Down Expand Up @@ -374,7 +375,13 @@ public function handleGetProperties(PropFind $propFind, \Sabre\DAV\INode $node)
}

// Check if the user published their display name
$ownerAccount = $this->accountManager->getAccount($owner);
try {
$ownerAccount = $this->accountManager->getAccount($owner);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am checking the code executed by getAccount but I can't find a place that throws the NoUserException (yet).
What I see is that inside this function, there is a call to getUser with default arguments, one of which is $insertIfNotExists = true. Doesn't this mean that if the user is not local, it gets created? Is that ok?

} catch (NoUserException) {
// do not lock process if owner is not local
return null;
}

$ownerNameProperty = $ownerAccount->getProperty(IAccountManager::PROPERTY_DISPLAYNAME);

// Since we are not logged in, we need to have at least the published scope
Expand Down
Loading