Skip to content

fix: remove double cache write in ObjectStoreStorage::touch #53462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 18, 2025
Merged

fix: remove double cache write in ObjectStoreStorage::touch #53462

merged 1 commit into from
Jun 18, 2025

Conversation

@icewind1991
Copy link
Member

the file_put_contents already puts all of those values into the cache

@icewind1991 icewind1991 added this to the Nextcloud 32 milestone Jun 12, 2025
@icewind1991 icewind1991 requested a review from a team as a code owner June 12, 2025 17:52
@icewind1991 icewind1991 added the 3. to review Waiting for reviews label Jun 12, 2025
@icewind1991 icewind1991 requested review from artonge, come-nc and nfebe and removed request for a team June 12, 2025 17:52
@icewind1991 @AndyScherzinger
fix: remove double cache write in ObjectStoreStorage::touch
2e1c316 
the file_put_contents already puts all of those values into the cache

Signed-off-by: Robin Appelman <robin@icewind.nl>
@AndyScherzinger AndyScherzinger force-pushed the objectstore-touch-double-cache branch from e15fb56 to 2e1c316 Compare June 18, 2025 20:22
@AndyScherzinger AndyScherzinger merged commit 419e0a5 into master Jun 18, 2025
202 of 209 checks passed
@AndyScherzinger AndyScherzinger deleted the objectstore-touch-double-cache branch June 18, 2025 20:53
@come-nc
Copy link
Contributor

come-nc commented Jun 23, 2025

@icewind1991 This broke CI:

There was 1 failure:

1) OCA\files_versions\tests\StorageTest::testExpireMaxAge
Failed asserting that actual size 3 matches expected size 2.

/home/runner/work/server/server/apps/files_versions/tests/StorageTest.php:80

https://github.com/nextcloud/server/actions/runs/15742834106/job/44373600796

This has been failing consistently on master since this PR was merged.

@icewind1991 icewind1991 mentioned this pull request Jun 23, 2025
Merged
@icewind1991
Copy link
Member Author

icewind1991 commented Jun 23, 2025 •
edited
Loading

Fix for test failures: #53650

@skjnldsv skjnldsv mentioned this pull request Aug 19, 2025
Merged
@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@artonge artonge artonge approved these changes

@come-nc come-nc come-nc approved these changes

@nfebe nfebe Awaiting requested review from nfebe nfebe is a code owner automatically assigned from nextcloud/server-backend

Assignees

No one assigned

Labels

3. to review Waiting for reviews

Projects

None yet

Milestone

Nextcloud 32

Development

Successfully merging this pull request may close these issues.

6 participants

@icewind1991 @come-nc @artonge @AndyScherzinger @skjnldsv