Skip to content

fix(UserRow): fallback to group name in case of undefined availableGroup #53436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 11, 2025
Merged

fix(UserRow): fallback to group name in case of undefined availableGroup #53436

merged 2 commits into from
Jun 11, 2025

Conversation

@Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Jun 11, 2025 •
edited
Loading

Summary

  • Should not throw an error, in case .find returns undefined

Checklist

@Antreesy
fix(UserRow): fallback to group name in case of undefined availableGroup
f55e194 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy added this to the Nextcloud 32 milestone Jun 11, 2025
@Antreesy Antreesy self-assigned this Jun 11, 2025
@Antreesy Antreesy requested a review from a team as a code owner June 11, 2025 12:41
@Antreesy Antreesy requested review from nfebe, sorbaugh and susnux and removed request for a team June 11, 2025 12:41
@Antreesy Antreesy requested a review from skjnldsv June 11, 2025 12:42
@Antreesy
Copy link
Contributor Author

/compile

@nextcloud-command
chore(assets): Recompile assets
96a57a1 
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@nextcloud-command nextcloud-command requested a review from a team as a code owner June 11, 2025 13:03
@Antreesy Antreesy merged commit ebaccf6 into master Jun 11, 2025
134 of 136 checks passed
@Antreesy Antreesy deleted the fix/53363/available-groups branch June 11, 2025 14:54
@Antreesy
Copy link
Contributor Author

Will be addressed in original backports

@skjnldsv
Copy link
Member

skjnldsv commented Jun 16, 2025 •
edited
Loading

Thanks @Antreesy 🙏
And sorry @susnux I don't know why I missed your very valid suggestion 🥲

@skjnldsv
Copy link
Member

/backport to stable31

@nextcloud nextcloud deleted a comment from backportbot bot Jun 16, 2025
@nextcloud nextcloud deleted a comment from backportbot bot Jun 16, 2025
@skjnldsv
Copy link
Member

/backport f55e194 to stable31

@nextcloud nextcloud deleted a comment from backportbot bot Jun 16, 2025
@backportbot backportbot bot mentioned this pull request Jun 16, 2025
Merged
@skjnldsv
Copy link
Member

/backport f55e194 to stable30

@backportbot backportbot bot mentioned this pull request Jun 16, 2025
Merged
@sorbaugh sorbaugh mentioned this pull request Jul 17, 2025
Open
@skjnldsv skjnldsv mentioned this pull request Aug 19, 2025
Merged
@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@susnux susnux susnux approved these changes

@DorraJaouad DorraJaouad DorraJaouad approved these changes

@nfebe nfebe Awaiting requested review from nfebe nfebe is a code owner automatically assigned from nextcloud/server-frontend

@sorbaugh sorbaugh Awaiting requested review from sorbaugh sorbaugh is a code owner automatically assigned from nextcloud/server-frontend

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees

@Antreesy Antreesy

Labels

3. to review Waiting for reviews feature: users and groups regression

Projects

None yet

Milestone

Nextcloud 32

Development

Successfully merging this pull request may close these issues.

6 participants

@Antreesy @skjnldsv @susnux @DorraJaouad @nextcloud-command